From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-omap-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DE51CC77B7E
	for <linux-omap@archiver.kernel.org>; Fri, 28 Apr 2023 07:46:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1345803AbjD1HqF (ORCPT <rfc822;linux-omap@archiver.kernel.org>);
        Fri, 28 Apr 2023 03:46:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1345807AbjD1Hpf (ORCPT
        <rfc822;linux-omap@vger.kernel.org>); Fri, 28 Apr 2023 03:45:35 -0400
Received: from muru.com (muru.com [72.249.23.125])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 689F84C03;
        Fri, 28 Apr 2023 00:44:24 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
        by muru.com (Postfix) with ESMTPS id 3203980B5;
        Fri, 28 Apr 2023 07:43:32 +0000 (UTC)
Date:   Fri, 28 Apr 2023 10:43:30 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     "Raghavendra, Vignesh" <vigneshr@ti.com>
Cc:     Reid Tonking <reidt@ti.com>, aaro.koskinen@iki.fi,
        jmkrzyszt@gmail.com, linux-omap@vger.kernel.org,
        linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: omap: Fix standard mode false ACK readings
Message-ID: <20230428074330.GJ14287@atomide.com>
References: <20230426194956.689756-1-reidt@ti.com>
 <445b3cbf-ffbc-6f77-47db-c30fc599e88f@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <445b3cbf-ffbc-6f77-47db-c30fc599e88f@ti.com>
Precedence: bulk
List-ID: <linux-omap.vger.kernel.org>
X-Mailing-List: linux-omap@vger.kernel.org

* Raghavendra, Vignesh <vigneshr@ti.com> [230427 13:18]:
> On 4/27/2023 1:19 AM, Reid Tonking wrote:
> > Using standard mode, rare false ACK responses were appearing with
> > i2cdetect tool. This was happening due to NACK interrupt triggering
> > ISR thread before register access interrupt was ready. Removing the
> > NACK interrupt's ability to trigger ISR thread lets register access
> > ready interrupt do this instead.

So is it safe to leave NACK interrupt unhandled until we get the next
interrupt, does the ARDY always trigger after hitting this?

Regards,

Tony