Re: [PATCH] ARM/musb: omap2: Remove global GPIO numbers from TUSB6010

[Greg KH <greg@kroah.com>]

On Sun, Apr 30, 2023 at 09:38:24PM +0200, Linus Walleij wrote:
> The TUSB6010 (MUSB) device is picking up some GPIO lines
> hardcoded by number and passing on to the TUSB6010 device
> when registering it.
> 
> Instead of nasty workarounds, provide a GPIO descriptor
> table and then make the TUSB6010 MUSB glue driver pick up
> the GPIO lines directly, convert it to an IRQ and pass down
> to the MUSB driver. OMAP2 is the only system using the
> TUSB6010.
> 
> Stash the GPIO descriptors in the glue layer and use
> then to power up and down the TUSB6010 on-demand, instead
> of using boardfile callbacks.
> 
> Since the OMAP2 boards are the only boards using the
> .set_power() and .board_set_power() callbacks, we can
> just delete them as the power is now handled directly
> in the TUSB6010 glue code.
> 
> Cc: Bin Liu <b-liu@ti.com>
> Cc: linux-usb@vger.kernel.org
> Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  arch/arm/mach-omap2/board-n8x0.c   | 71 ++++++++----------------------
>  arch/arm/mach-omap2/usb-tusb6010.c | 20 ++-------
>  arch/arm/mach-omap2/usb-tusb6010.h | 12 +++++
>  drivers/usb/musb/musb_core.c       |  1 -
>  drivers/usb/musb/musb_core.h       |  2 -
>  drivers/usb/musb/tusb6010.c        | 53 ++++++++++++++++------
>  include/linux/usb/musb.h           | 13 ------
>  7 files changed, 73 insertions(+), 99 deletions(-)
>  create mode 100644 arch/arm/mach-omap2/usb-tusb6010.h

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>