From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E3CC88CB4 for ; Tue, 13 Jun 2023 10:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238776AbjFMKiv (ORCPT ); Tue, 13 Jun 2023 06:38:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240655AbjFMKiv (ORCPT ); Tue, 13 Jun 2023 06:38:51 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78FF9187 for ; Tue, 13 Jun 2023 03:38:49 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-30fd128eebcso127271f8f.2 for ; Tue, 13 Jun 2023 03:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686652728; x=1689244728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6d+VLj6m3MAAbwrIUd63IBRinbYN+a8k/C8reDLCUoA=; b=hgjHCdmVZj17ygZWDKclgn2+Ytse1qSnmaG4LRvuBitz3LJyh5HgOVAUSo0/r7wbdt fdSIKGBQtVODe5/DiwzNAY75tQn14eC3cn9Q2yhq2toPlE76Oa5oFJdV9l1XnL0YG0RH fxvfeGPQ4hK4wvvH1FIqK7kR5+J3EkpRC2wIwVTAmEGdctNMUqczSpR/pqHqlcdrvXNx w+5FbTeVgBNFZVVGyto35QUzWBVlGziPVY46F9DgTYoTMe+PwdW3jVov2buriiM7Vv2s PvmiMKy9I+IiUkPF6osBSwKSkROBznVLomANfzqMBfERLZUvUZy0htIwFzMk6D4nAIGS /3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686652728; x=1689244728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6d+VLj6m3MAAbwrIUd63IBRinbYN+a8k/C8reDLCUoA=; b=lPvbOH3JLHJbadLQbMUxcmAsBTSKFH7CEFTfctsHx0mlNCp2/w9l1u4cIsvwHncM0i 7kdtK2d9pRtlyWp8xeOaOhrjzdPgkvN21oCquVkegIYFz/TO5MIecA5EtixyKgPcwqeu DEw5NJEqB6DpxQLZwL7PZ2lDu3OuU6MDI8TSrqmcNv9ZGOFRBHRv5d5E4sgL7iefCZ4Z q49JKXQORLYozaGdlH7bh7zaBf75JUIeiTFfZoO45xR93WeSFqx/XFCmzRuwRn+yqfxs Q6OqqKL3Tklo0fq3BbT9ZYR2IPR4R0/w2t709+sg+NXcGsl2sYuXIBKi6p9eXTk6/fqj wO7w== X-Gm-Message-State: AC+VfDx73wLQJyXU92OduRijwlMmqZoCr01yeVzAmM6vBjgXvCJQEpT7 W1j9Cdp9bhdIaLS922JiNzVHhw== X-Google-Smtp-Source: ACHHUZ5HGIJRgD5nl4Qh50NEPcobvGP0CTVSW1VYZZsJoGlj0SicoFaUzO4TaUafxBw4qtclMnMW2w== X-Received: by 2002:a5d:6a0b:0:b0:309:46a4:6378 with SMTP id m11-20020a5d6a0b000000b0030946a46378mr5778964wru.12.1686652727984; Tue, 13 Jun 2023 03:38:47 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id f9-20020a5d6649000000b0030f9dc63ff1sm13001387wrw.88.2023.06.13.03.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 03:38:47 -0700 (PDT) Date: Tue, 13 Jun 2023 11:38:45 +0100 From: Daniel Thompson To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , Rich Felker , John Paul Adrian Glaubitz , stable@vger.kernel.org Subject: Re: [PATCH v2 03/38] backlight/gpio_backlight: Compare against struct fb_info.device Message-ID: <20230613103845.GC169438@aspen.lan> References: <20230612141352.29939-1-tzimmermann@suse.de> <20230612141352.29939-4-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612141352.29939-4-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Jun 12, 2023 at 04:07:41PM +0200, Thomas Zimmermann wrote: > Struct gpio_backlight_platform_data refers to a platform device within > the Linux device hierarchy. The test in gpio_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Signed-off-by: Thomas Zimmermann > Fixes: 8b770e3c9824 ("backlight: Add GPIO-based backlight driver") > Cc: Laurent Pinchart > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: linux-sh@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ Reviewed-by: Daniel Thompson Daniel.