From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60402C88CB6 for ; Tue, 13 Jun 2023 10:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240690AbjFMKkM (ORCPT ); Tue, 13 Jun 2023 06:40:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241868AbjFMKjn (ORCPT ); Tue, 13 Jun 2023 06:39:43 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B447129 for ; Tue, 13 Jun 2023 03:39:40 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-30fc42fcbc7so1426345f8f.1 for ; Tue, 13 Jun 2023 03:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686652779; x=1689244779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L+0q/8B3X2O+bLieXF8c9g+8ohNwELNU1kRNH19cJQQ=; b=mp5t8BFsJLvB4B2RBPo6x6uNyPCi8jDPJJpT5/LpidCyzOQv4FCXKrMWr1ZoGeWb2S 1dBOQjE7wNbB2/NIq8xC5IgXRwNRGlVnZW3Z4RXFfWXN3WDAjIuuNAySekfhnk34w5wO NzDIjtTF8SXSuX25qLMn3huo8p/83/zQMv/5E4FEAXUWYyMCx8Mo+LAzcn9buVVIEf25 xq6WyCppmw0R4kg6OL44jDGiDE0u+RRVrPQ0ZksXnqIcz16sfbXTylvjE97DH2Pg1vn+ u4HS9GU54OKGBiesVcpBbKbzyQtzvsmO+sXxWBrgzd+eRZlTzu8i2amAs2BDVfmzc8Gh L22w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686652779; x=1689244779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L+0q/8B3X2O+bLieXF8c9g+8ohNwELNU1kRNH19cJQQ=; b=AbU46Md7boMjyeSZEX5yylTQgapF3miIVU7dng4fYcm246eS83Oy9dni3szeh+NgB6 P/6er2QoVY18jsArMD/ltyaZBHifvGZYY/xs6LhBIrzVPL86ybAEdc9/AudRhR/hGsDf PPKm7QVDMhpy5Wlpa3TrL+2f3oexHUgb5Z66eqfs8MAVE4/pv2PbYaiB8haLkRMul/A6 IN+TMuBsjiD8y8wF0M3XxTQGGmVsr88vWq+0I6M52nujPBeHBBVv+KfNmfpymabcHY3u tZQ8lqH7DveHs3uQ97/Olh7yj0zhjVaF/SZeBWywyxK7bWSfVqyv6zg/WlhpX9jL2G6o Neig== X-Gm-Message-State: AC+VfDypbfk2qYXbnBkMDuaoC1swr+AMHIZg15X5Ir94S6YP2rorqXOp NDANil2RV+eXurgPww2EKhx9Yg== X-Google-Smtp-Source: ACHHUZ4QXHWcQ+EF1TxBMcwYsV+sIp0eKcDzBEmcY5jt8MfrsM/QF7URk3vwRqxNRqLqrU6BbwKwDg== X-Received: by 2002:a5d:508a:0:b0:30f:caf6:5bde with SMTP id a10-20020a5d508a000000b0030fcaf65bdemr1780025wrt.32.1686652779043; Tue, 13 Jun 2023 03:39:39 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id h2-20020a5d5482000000b0030fbc96bdffsm7123579wrv.25.2023.06.13.03.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 03:39:38 -0700 (PDT) Date: Tue, 13 Jun 2023 11:39:36 +0100 From: Daniel Thompson To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, lee@kernel.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , stable@vger.kernel.org Subject: Re: [PATCH v2 05/38] backlight/lv5207lp: Compare against struct fb_info.device Message-ID: <20230613103936.GE169438@aspen.lan> References: <20230612141352.29939-1-tzimmermann@suse.de> <20230612141352.29939-6-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612141352.29939-6-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Jun 12, 2023 at 04:07:43PM +0200, Thomas Zimmermann wrote: > Struct lv5207lp_platform_data refers to a platform device within > the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Fixes: 82e5c40d88f9 ("backlight: Add Sanyo LV5207LP backlight driver") > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: linux-sh@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ > Reviewed-by: Javier Martinez Canillas Reviewed-by: Daniel Thompson Daniel.