From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08454EB64DC for ; Wed, 14 Jun 2023 13:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245250AbjFNNwR (ORCPT ); Wed, 14 Jun 2023 09:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245251AbjFNNwM (ORCPT ); Wed, 14 Jun 2023 09:52:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579142684; Wed, 14 Jun 2023 06:52:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB4D860F06; Wed, 14 Jun 2023 13:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51FC5C433C0; Wed, 14 Jun 2023 13:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750725; bh=CO5xc8YPPQWPDb40OvDsmBIPZj3o5j1/a0jNwh4QVN4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dMU49nXfjD0xUXILvTvlDXF8NMUb2VlD+tfLPuwxXKPYNwvghwaxBU+9u2dFQKFMo XG+fJzMiwNtoO0PTs068LLyp6fKUG1EThsNPAAUJAhH3cSh2dtIxXzlGd88HQv484/ ZAlAl83NY+7EBAOlT+shnVTY6WCtv7JBz6vvP95GR1zrwO/OawUrUrsW1MuGojBZsU ioUn869QlwHx9xsO4FSJtFNrH+83l/Y//XX2lHjKyHDmUnW2nJ8wKCVlv7fkPfS+Te paPKw8aaxdheBAC+5kYRLZAtm7ruqPpKky4hXCGyPIRxJST++sKSPrIR2izAJsgq5m lVIOfM71BDihA== Date: Wed, 14 Jun 2023 14:51:57 +0100 From: Lee Jones To: Thomas Zimmermann Cc: daniel@ffwll.ch, javierm@redhat.com, sam@ravnborg.org, deller@gmx.de, geert+renesas@glider.be, daniel.thompson@linaro.org, jingoohan1@gmail.com, dan.carpenter@linaro.org, michael.j.ruhl@intel.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Laurent Pinchart , stable@vger.kernel.org Subject: Re: [PATCH v3 01/38] backlight/bd6107: Compare against struct fb_info.device Message-ID: <20230614135157.GU3635807@google.com> References: <20230613110953.24176-1-tzimmermann@suse.de> <20230613110953.24176-2-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230613110953.24176-2-tzimmermann@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Tue, 13 Jun 2023, Thomas Zimmermann wrote: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device. > > Fixes a bug in the backlight driver and prepares fbdev for making > struct fb_info.dev optional. > > v2: > * move renames into separate patch (Javier, Sam, Michael) > > Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: dri-devel@lists.freedesktop.org > Cc: # v3.12+ > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Sam Ravnborg > Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/bd6107.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Can the Backlight patches be applied without the others and visa versa? -- Lee Jones [李琼斯]