From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7DFC001E0 for ; Wed, 19 Jul 2023 15:38:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjGSPiy (ORCPT ); Wed, 19 Jul 2023 11:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbjGSPix (ORCPT ); Wed, 19 Jul 2023 11:38:53 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48290B7; Wed, 19 Jul 2023 08:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689781132; x=1721317132; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7Ov7681vkWQmGXJ8qz/HV+aSvOi5QL9idK+76+29III=; b=LMRD8eBrSkXDE+MzC1p69mW3aAoM4g1gFiQJBw8l0sXZCSeM2+MN4+cU UBfSecO8sXJDE0zZOWBvcTOAInNVDLKVX+fNJZ18l0VwQx5HEkuaTeP1f crDynJ3NDGcpu18mAzkHOy3fs8JVW9/DOUkvR8acwuND3N2J31MPvoCvh XPBOy0hlDK4Z0qvxlAPrS2B7N78O4SBV7Q/twQCDmpvJ6xcdosW+ktOIL ao3CJBHMmVmftDQ7QHNiXb52TvdrGqr5TEwU8dI5GgSyy7b+e9uVCsd3y QNLsJvn/J0BjY1bGF+Gq7VHcF+xeGPKlnFEv1i2/AhRJ8RN5YZiXDkMNt A==; X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="452874358" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="452874358" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 08:38:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="718022098" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="718022098" Received: from lkp-server02.sh.intel.com (HELO 36946fcf73d7) ([10.239.97.151]) by orsmga007.jf.intel.com with ESMTP; 19 Jul 2023 08:38:47 -0700 Received: from kbuild by 36946fcf73d7 with local (Exim 4.96) (envelope-from ) id 1qM9G1-00054P-15; Wed, 19 Jul 2023 15:38:30 +0000 Date: Wed, 19 Jul 2023 23:38:11 +0800 From: kernel test robot To: Tony Lindgren , Greg Kroah-Hartman , Jiri Slaby Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andy Shevchenko , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: core: Add support for dev_name:0.0 naming for kernel console Message-ID: <202307192334.nrgSDnfu-lkp@intel.com> References: <20230719051525.46494-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719051525.46494-1-tony@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tony, kernel test robot noticed the following build errors: [auto build test ERROR on tty/tty-testing] [also build test ERROR on tty/tty-next linus/master v6.5-rc2 next-20230719] [cannot apply to tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/serial-core-Add-support-for-dev_name-0-0-naming-for-kernel-console/20230719-131657 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20230719051525.46494-1-tony%40atomide.com patch subject: [PATCH] serial: core: Add support for dev_name:0.0 naming for kernel console config: x86_64-randconfig-r013-20230718 (https://download.01.org/0day-ci/archive/20230719/202307192334.nrgSDnfu-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230719/202307192334.nrgSDnfu-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307192334.nrgSDnfu-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/tty/serial/serial_core.c:3337:17: error: no member named 'port_id' in 'struct uart_port' port->port_id); ~~~~ ^ 1 error generated. vim +3337 drivers/tty/serial/serial_core.c 3324 3325 /* 3326 * Add preferred console if configured on kernel command line with naming 3327 * "console=dev_name:0.0". 3328 */ 3329 static int serial_core_add_preferred_console(struct uart_driver *drv, 3330 struct uart_port *port) 3331 { 3332 char *port_match, *opt, *name; 3333 int len, ret = 0; 3334 3335 port_match = kasprintf(GFP_KERNEL, "console=%s:%i.%i", 3336 dev_name(port->dev), port->ctrl_id, > 3337 port->port_id); 3338 if (!port_match) 3339 return -ENOMEM; 3340 3341 opt = strstr(saved_command_line, port_match); 3342 if (!opt) 3343 goto free_port_match; 3344 3345 len = strlen(port_match); 3346 3347 if (strlen(opt) > len + 1 && opt[len] == ',') 3348 opt += len + 1; 3349 else 3350 opt = NULL; 3351 3352 name = kstrdup(drv->dev_name, GFP_KERNEL); 3353 if (!name) { 3354 ret = -ENOMEM; 3355 goto free_port_match; 3356 } 3357 3358 add_preferred_console(name, port->line, opt); 3359 3360 kfree(name); 3361 3362 free_port_match: 3363 kfree(port_match); 3364 3365 return ret; 3366 } 3367 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki