linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Dhruva Gole" <d-gole@ti.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Johan Hovold" <johan@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-omap@vger.kernel.org
Subject: [PATCH v2 0/3] Serial core controller port device name fixes
Date: Thu, 20 Jul 2023 08:10:13 +0300	[thread overview]
Message-ID: <20230720051021.14961-1-tony@atomide.com> (raw)

A few issues have been found with device naming for the serial core
controller port device. These issues currently affect mostly the output
for /sys/bus/serial-base/devices, but need to be also fixed to avoid
port addressing issues later on. It would be good to get these fixes into
the -rc cycle to avoid folks possibly trying to use the incorrect sysfs
port device names for finding uart ports for example.

Regards,

Tony

Changes since v1:
- Port id cannot be negative as noted by Jiri

- Controller id cannot be negative as noted by Andy

- Port name is missing the controller instance as noted by Andy

Tony Lindgren (3):
  serial: core: Controller id cannot be negative
  serial: core: Fix serial core port id to not use port->line
  serial: core: Fix serial core controller port name to show controller
    id

 drivers/tty/serial/8250/8250_core.c  |  2 ++
 drivers/tty/serial/serial_base_bus.c | 33 ++++++++++++++++++----------
 include/linux/serial_core.h          |  3 ++-
 3 files changed, 25 insertions(+), 13 deletions(-)

-- 
2.41.0

             reply	other threads:[~2023-07-20  5:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  5:10 Tony Lindgren [this message]
2023-07-20  5:10 ` [PATCH v2 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-20 19:33   ` Greg Kroah-Hartman
2023-07-21  5:43     ` Tony Lindgren
2023-07-21  6:00       ` Greg Kroah-Hartman
2023-07-21  6:15         ` Tony Lindgren
2023-07-21  6:57           ` Tony Lindgren
2023-07-21  7:06             ` Greg Kroah-Hartman
2023-07-21  7:17               ` Tony Lindgren
2023-07-21 10:09                 ` Andy Shevchenko
2023-07-25  6:56                   ` Tony Lindgren
2023-07-20  5:10 ` [PATCH v2 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-20  5:10 ` [PATCH v2 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720051021.14961-1-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=d-gole@ti.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johan@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).