From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB82C0015E for ; Thu, 20 Jul 2023 15:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjGTPRp (ORCPT ); Thu, 20 Jul 2023 11:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbjGTPRo (ORCPT ); Thu, 20 Jul 2023 11:17:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1F013E; Thu, 20 Jul 2023 08:17:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACE6161B46; Thu, 20 Jul 2023 15:17:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65510C433C9; Thu, 20 Jul 2023 15:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689866263; bh=qYHzhCAUIzF07jkVYTmVpGY6QuZJidrqSGysBgEQ+mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P16yasElhZTEVFOLsqDGNj4lriTO6FsUW8YABCZuFpIMFix1NMiwqPaxeOXOJGNOk VfOItlUQjULagwjy03aN/moX4p0fVX1uyxELFFx7ST2p8Y2LanDjA80FYWJYqo902U B1dPtPEPCXdcO2vuWr+smF+q+CudYO+XVVfGf4muamAjCqLdYs5ly7RxarL53ghMO1 c7z4tglFywO9GUJRvnBTv0bIV43yd7al05bkCq1t3oVmo4Q8veUrMy96QxeUPfZzHU 5XBwXPyYA9MApwhmFlvKbYMA+lkCuL/2H3vC+cqcQMFlqFT90CDLJVT0Z8BkAASI1o Buaey1/Wipc4w== Date: Thu, 20 Jul 2023 08:17:41 -0700 From: Jakub Kicinski To: Md Danish Anwar Cc: MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Eric Dumazet , "David S. Miller" , , , , , , , Subject: Re: [EXTERNAL] Re: [PATCH v10 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Message-ID: <20230720081741.0c32d5e6@kernel.org> In-Reply-To: <17cd1e70-73bc-78d5-7e9d-7b133d6f464b@ti.com> References: <20230719082755.3399424-1-danishanwar@ti.com> <20230719082755.3399424-3-danishanwar@ti.com> <20230719213543.0380e13e@kernel.org> <17cd1e70-73bc-78d5-7e9d-7b133d6f464b@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, 20 Jul 2023 17:12:50 +0530 Md Danish Anwar wrote: > Patch 1: Introduce Firmware mapping for the driver (icss_switch_map.h) > > Patch 2: Introduce mii helper APIs. (icssg_mii_rt.h and icssg_mii_cfg.h). This > patch will also introduce basic prueth and emac structures in icssg_prueth.h as > these structures will be used by the helper APIs. > > Patch 3: Introduce firmware configuration and classification APIs. > (icssg_classifier.c, icssg_config.h and icssg_config.c) > > Patch 4: Introduce APIs for ICSSG Queues (icssg_queues.c) > > Patch 5: Introduce ICSSG Ethernet driver. (icssg_prueth.c and icssg_prueth.h) > This patch will enable the driver and basic functionality can work after this > patch. This patch will be using all the APIs introduced earlier. This patch > will also include Kconfig and Makefile changes. > > Patch 6: Enable standard statistics via ndo_get_stats64 > > Patch 7: Introduce ethtool ops for ICSSG > > Patch 8: Introduce power management support (suspend / resume APIs) > > However this structure of patches will introduce some APIs earlier (in patch > 2,3 and 4) which will be used later by patch 5. I hope it will be OK to > introduce APIs and macros earlier and use them later. > > This restructuring will shorten all the individual patches. However patch 5 > will still be a bit large as patch 5 introduces all the neccessary APIs as > driver probe / remove, ndo open / close, tx/rx etc. > > Currnetly this single patch has close to 4000 insertion and is touching 12 > files. After restructring patch 5 will have around 1800 insertions and will > touch only 4 files (icssg_prueth.c, icssg_prueth.h, Kconfig, Makefile). This is > still significant improvement. > > Please let me know if this is OK. SGTM, thanks! One patch still being larger than others is a bit inevitable. > Also this patch has Reviewed-By tag of Andrew. Can I carry forward his > Reviewed-By tag in all patches or do I need to drop it? If the code is identical I reckon you can carry it.