From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative
Date: Fri, 21 Jul 2023 10:17:53 +0300 [thread overview]
Message-ID: <20230721071753.GR5194@atomide.com> (raw)
In-Reply-To: <2023072109-fidelity-modular-4074@gregkh>
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [230721 07:07]:
> On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [230721 06:19]:
> > > Looks like linux-serial not getting added is caused by MAINTAINERS
> > > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
> > > causes get_maintainer.pl to not show linux-serial for a patch touching
> > > serial_base_bus.c.. And this will causes git send-email to not pick up
> > > linux-serial.. I'll send a patch for MAINTAINERS file too.
> >
> > And the TTY LAYER is missing the list entries.. Does something like below
> > make sense to you guys to include lkml and linux-serial for TTY LAYER?
> >
> > Regards,
> >
> > Tony
> >
> > 8< ---------------------
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/
> > TTY LAYER
> > M: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > M: Jiri Slaby <jirislaby@kernel.org>
> > +L: linux-kernel@vger.kernel.org
> > +L: linux-serial@vger.kernel.org
> > S: Supported
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > F: Documentation/driver-api/serial/
> > F: drivers/tty/
> > +F: drivers/tty/serial/serial_base.h
> > +F: drivers/tty/serial/serial_base_bus.c
> > F: drivers/tty/serial/serial_core.c
> > +F: drivers/tty/serial/serial_ctrl.c
> > +F: drivers/tty/serial/serial_port.c
> > F: include/linux/selection.h
> > F: include/linux/serial.h
> > F: include/linux/serial_core.h
> > --
> > 2.41.0
>
> Seems sane to me, I've always wondered why some serial patches didn't
> end up on the linux-serial list.
OK will send. Also I noticed that using git send-email --cc-cover does
not work for the cover letter.. It tries to use the first patch that
is the cover letter or something like that. I'm going back to my custom
email scripts for now rather than try to have git handle things
automagically.
Regards,
Tony
next prev parent reply other threads:[~2023-07-21 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 5:10 [PATCH v2 0/3] Serial core controller port device name fixes Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-20 19:33 ` Greg Kroah-Hartman
2023-07-21 5:43 ` Tony Lindgren
2023-07-21 6:00 ` Greg Kroah-Hartman
2023-07-21 6:15 ` Tony Lindgren
2023-07-21 6:57 ` Tony Lindgren
2023-07-21 7:06 ` Greg Kroah-Hartman
2023-07-21 7:17 ` Tony Lindgren [this message]
2023-07-21 10:09 ` Andy Shevchenko
2023-07-25 6:56 ` Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-20 5:10 ` [PATCH v2 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721071753.GR5194@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).