From: Dhruva Gole <d-gole@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, Dave Gerlach <d-gerlach@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Keerthy <j-keerthy@ti.com>, Kevin Hilman <khilman@baylibre.com>,
Nishanth Menon <nm@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] bus: ti-sysc: Fix build warning for 64-bit build
Date: Wed, 9 Aug 2023 15:10:59 +0530 [thread overview]
Message-ID: <20230809094059.7dzf7kihenxoor47@dhruva> (raw)
In-Reply-To: <20230809092722.11000-1-tony@atomide.com>
On Aug 09, 2023 at 12:27:20 +0300, Tony Lindgren wrote:
> Fix "warning: cast from pointer to integer of different size" on 64-bit
> builds.
>
> Note that this is a cosmetic fix at this point as the driver is not yet
> used for 64-bit systems.
>
> Fixes: feaa8baee82a ("bus: ti-sysc: Implement SoC revision handling")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/bus/ti-sysc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -3104,7 +3104,7 @@ static int sysc_init_static_data(struct sysc *ddata)
>
> match = soc_device_match(sysc_soc_match);
> if (match && match->data)
> - sysc_soc->soc = (int)match->data;
> + sysc_soc->soc = (enum sysc_soc)match->data;
Thanks for the suggestion Nishanth,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Maybe something unrelated to this patch, but the driver has some minor
warning when built with W=1:
make W=1 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/bus/ti-sysc.o
drivers/bus/ti-sysc.c:156: warning: Function parameter or member 'sysconfig' not described in 'sysc'
>
> /*
> * Check and warn about possible old incomplete dtb. We now want to see
> --
> 2.41.0
--
Best regards,
Dhruva Gole <d-gole@ti.com>
next prev parent reply other threads:[~2023-08-09 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 9:27 [PATCH v2 1/3] bus: ti-sysc: Fix build warning for 64-bit build Tony Lindgren
2023-08-09 9:27 ` [PATCH v2 2/3] bus: ti-sysc: Build driver for TI K3 SoCs Tony Lindgren
2023-08-09 11:59 ` Nishanth Menon
2023-08-09 9:27 ` [PATCH v2 3/3] bus: ti-sysc: Configure uart quirks for k3 SoC Tony Lindgren
2023-08-09 12:00 ` Nishanth Menon
2023-08-09 9:40 ` Dhruva Gole [this message]
2023-08-09 9:55 ` [PATCH v2 1/3] bus: ti-sysc: Fix build warning for 64-bit build Tony Lindgren
2023-08-09 11:59 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809094059.7dzf7kihenxoor47@dhruva \
--to=d-gole@ti.com \
--cc=d-gerlach@ti.com \
--cc=faiz_abbas@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox