From: Tony Lindgren <tony@atomide.com>
To: Grant B Adams <nemith592@gmail.com>
Cc: linux-omap@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict
Date: Tue, 5 Sep 2023 09:35:55 +0300 [thread overview]
Message-ID: <20230905063555.GZ11676@atomide.com> (raw)
In-Reply-To: <20230823085430.6610-1-nemith592@gmail.com>
* Grant B Adams <nemith592@gmail.com> [230823 08:54]:
> Both the tps65217-charger and vbus drivers are trying to allocate the same
> TPS65217 device interrupt line (TPS65217 is a TI power management IC)
> which results in the following error and a probe failure:
>
> genirq: Flags mismatch irq 148. 00002000 (vbus) vs. 00000000
> (tps65217-charger)
>
> For the Beaglebone Black's config the tps65217-charger driver is currently
> disabled and therefore no conflict. Based on comments from Robert C Nelson
> this driver has been disabled for a long time and he is uncertain on the
> reasons why it was disabled. With a battery connected to the BBB, I
> re-enabled the tps65217-charger driver which resulted in the
> abovementioned.
>
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.
Looks good to me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2023-09-05 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 8:54 [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict Grant B Adams
2023-08-23 8:54 ` [PATCH v2 1/2] power: supply: " Grant B Adams
2023-09-15 20:43 ` Sebastian Reichel
2023-08-23 8:54 ` [PATCH v2 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger " Grant B Adams
2023-09-05 6:35 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905063555.GZ11676@atomide.com \
--to=tony@atomide.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nemith592@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).