From: Andreas Kemnade <andreas@kemnade.info>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Patrik Dahlström" <risca@dalakolonin.se>,
letux-kernel@openphoenux.org, kernel@pyra-handheld.com,
linux-omap@vger.kernel.org,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Subject: Re: ABE/AESS on modern kernel: clocks, hwmods etc.
Date: Tue, 5 Sep 2023 16:44:53 +0200 [thread overview]
Message-ID: <20230905164453.3be3f33a@aktux> (raw)
In-Reply-To: <9CF135C5-85B6-47CC-985C-FE6F4B24407D@goldelico.com>
On Tue, 5 Sep 2023 14:42:03 +0200
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> Hi Tony,
>
> > Am 05.09.2023 um 08:12 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > The key observation is that the abe_iclk references in the DTS seem to be nowhere referenced
> >> (which may or may not be an issue):
> >>
> >> https://github.com/goldelico/letux-kernel/blob/letux/aess-v12/arch/arm/boot/dts/ti/omap/omap44xx-clocks.dtsi#L509
> >> https://github.com/goldelico/letux-kernel/blob/letux/aess-v12/arch/arm/boot/dts/ti/omap/omap54xx-clocks.dtsi#L161
> >
> > So I guess the ick is in the dts the ocp_abe_iclk@528 for omap4 and
> > abe_iclk@528 for omap5. Seems like the driver should request them, I recall
> > that the interconnect target module does not need the ick to access sysc
> > and revision registers.
>
> Yes, that is what I suspect but I don't know how to request them.
>
add ,"ick" to the clock-names line in the target-module?
and ,<&ocp_abe_iclk> to the target module?
Regards,
Andreas
next prev parent reply other threads:[~2023-09-05 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53bc74ae-a2d5-40d5-8d51-bc0f062fcd15@email.android.com>
[not found] ` <45F44D32-E846-4A53-BA20-9C78CD4411F3@goldelico.com>
[not found] ` <ZO4SWw/rbJH5Dpbq@dalakolonin.se>
[not found] ` <A029FB33-9FBB-4CE5-92D5-597E10B3A032@goldelico.com>
[not found] ` <ZPH5Yr3w7ruN/io0@dalakolonin.se>
[not found] ` <05B47ED4-CA2C-4754-ABB1-0591E9018E57@goldelico.com>
[not found] ` <ZPLYG16mwiwt9G9R@dalakolonin.se>
2023-09-02 7:27 ` ABE/AESS on modern kernel: clocks, hwmods etc H. Nikolaus Schaller
2023-09-02 10:26 ` Andreas Kemnade
2023-09-04 6:34 ` Tony Lindgren
[not found] ` <03375B42-C86E-4B37-98C2-C1FBA7AB68B6@goldelico.com>
2023-09-05 6:12 ` Tony Lindgren
2023-09-05 12:42 ` H. Nikolaus Schaller
2023-09-05 14:44 ` Andreas Kemnade [this message]
2023-09-05 15:09 ` H. Nikolaus Schaller
2023-09-05 15:48 ` H. Nikolaus Schaller
2023-09-05 16:53 ` H. Nikolaus Schaller
2023-09-06 13:50 ` Patrik Dahlström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905164453.3be3f33a@aktux \
--to=andreas@kemnade.info \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=risca@dalakolonin.se \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox