From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EECAEB8FAF for ; Wed, 6 Sep 2023 11:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237753AbjIFLDn (ORCPT ); Wed, 6 Sep 2023 07:03:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236949AbjIFLDn (ORCPT ); Wed, 6 Sep 2023 07:03:43 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 764501BB; Wed, 6 Sep 2023 04:03:39 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9CAFB8050; Wed, 6 Sep 2023 11:03:38 +0000 (UTC) Date: Wed, 6 Sep 2023 14:03:37 +0300 From: Tony Lindgren To: Adam Ford Cc: linux-omap@vger.kernel.org, aford@beaconembedded.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: ti-sysc: Fix missing AM35xx SoC matching Message-ID: <20230906110337.GC11676@atomide.com> References: <20230906093244.99292-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906093244.99292-1-aford173@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Adam Ford [230906 12:33]: > Fix this by treating the AM35xx as a SOC_3430, and the error > conditions will disappear. Looks good to me except let's just add SOC_AM35 to enum sysc_soc rather than tag am3517 with SOC_3430. We already have checks for SOC_3430 for several devices and the quirks may not be compatible across AM35 and 3430. Regards, Tony