linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>, stable <stable@vger.kernel.org>
Subject: Re: AM3517 Timer busy regression on 6.1.y branch
Date: Thu, 7 Sep 2023 08:41:31 +0300	[thread overview]
Message-ID: <20230907054131.GH11676@atomide.com> (raw)
In-Reply-To: <CAHCN7xLkDEBDejgrmdZ-UHVbA9umL35TT=oXUJMwKNLJFYjH2A@mail.gmail.com>

* Adam Ford <aford173@gmail.com> [230906 15:11]:
> On Wed, Sep 6, 2023 at 9:40 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Adam Ford <aford173@gmail.com> [230905 15:02]:
> > > Tony et al
> > > ,
> > > I am trying to run the 6.1.y branch on an AM3517-EVM.
> > >
> > > There are two GPT that throw an error:
> > >
> > >  ti-sysc: probe of 48318000.target-module failed with error -16
> > >  ti-sysc: probe of 49032000.target-module failed with error -16
> >
> > These two timers are in use as clocksource and clockevent reserved
> > by timer-ti-dm-systimer.
> >
> > > I did some minor investigation and found sysc_check_active_timer() is
> > > returning the busy condition.
> > >
> > > I tracked this back a bit further and found that if I revert commit
> > > a12315d6d270  ("bus: ti-sysc: Make omap3 gpt12 quirk handling SoC
> > > specific"), this error condition goes away.
> > >
> > > It almost looks to me like sysc_check_active_timer is defaulting to
> > > -EBUSY when the SoC is not 3430, but the sysc_soc_match[] doesn't
> > > appear to match to AM3517.
> > >
> > > I think the proper solution is to treat the AM35* as 3430.  Do you
> > > agree with that approach?
> > >
> > > If so, I'll submit a patch with a fixes tag. I am also wondering how
> > > far back I should mark the fixes tag.
> >
> > Yes am3517 is very similar to 3430. Sounds like the patch would
> > be needed also against the current kernels, right?
> 
> I submitted a patch against the mainline kernel [1] with fixes tags to
> hopefully back-port them to 6.1.y.  Any feedback and/or assistance you
> can help to move them forward would be appreciated.

Thanks v2 looks good to me, will be adding it to fixes and it should get
picked automatically to stable kernels.

Regards,

Tony

      reply	other threads:[~2023-09-07  5:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 15:02 AM3517 Timer busy regression on 6.1.y branch Adam Ford
2023-09-06  7:58 ` Tony Lindgren
2023-09-06 15:11   ` Adam Ford
2023-09-07  5:41     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907054131.GH11676@atomide.com \
    --to=tony@atomide.com \
    --cc=aford173@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).