From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Grant B Adams <nemith592@gmail.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: Fix tps65217-charger vs vbus irq conflict
Date: Fri, 15 Sep 2023 22:43:25 +0200 [thread overview]
Message-ID: <20230915204325.mokj2nmdwjdekxfo@mercury.elektranox.org> (raw)
In-Reply-To: <20230823085430.6610-2-nemith592@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
Hi,
On Wed, Aug 23, 2023 at 10:54:29AM +0200, Grant B Adams wrote:
> Enabling the tps65217-charger driver/module causes an interrupt conflict
> with the vbus driver resulting in a probe failure.
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.
>
> Signed-off-by: Grant B Adams <nemith592@gmail.com>
> ---
Your commit message does not explain why IRQF_ONESHOT is dropped;
IRQF_ONESHOT and IRQF_SHARED are not mutually exclusive.
-- Sebastian
> drivers/power/supply/tps65217_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c
> index a4bc9f2a10bc..6f68becdbfd0 100644
> --- a/drivers/power/supply/tps65217_charger.c
> +++ b/drivers/power/supply/tps65217_charger.c
> @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
> for (i = 0; i < NUM_CHARGER_IRQS; i++) {
> ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,
> tps65217_charger_irq,
> - IRQF_ONESHOT, "tps65217-charger",
> + IRQF_SHARED, "tps65217-charger",
> charger);
> if (ret) {
> dev_err(charger->dev,
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-15 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 8:54 [PATCH v2 0/2] Fix tps65217-charger vs vbus irq conflict Grant B Adams
2023-08-23 8:54 ` [PATCH v2 1/2] power: supply: " Grant B Adams
2023-09-15 20:43 ` Sebastian Reichel [this message]
2023-08-23 8:54 ` [PATCH v2 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger " Grant B Adams
2023-09-05 6:35 ` [PATCH v2 0/2] Fix tps65217-charger vs vbus " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915204325.mokj2nmdwjdekxfo@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nemith592@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).