Re: [PATCH v2] i2c: omap: Fix standard mode false ACK readings

Reid Tonking
2023-04-28T18:31:13Z

On 10:43-20230428, Tony Lindgren wrote:
> * Raghavendra, Vignesh <vigneshr@ti.com> [230427 13:18]:
> > On 4/27/2023 1:19 AM, Reid Tonking wrote:
> > > Using standard mode, rare false ACK responses were appearing with
> > > i2cdetect tool. This was happening due to NACK interrupt triggering
> > > ISR thread before register access interrupt was ready. Removing the
> > > NACK interrupt's ability to trigger ISR thread lets register access
> > > ready interrupt do this instead.
>
> So is it safe to leave NACK interrupt unhandled until we get the next
> interrupt, does the ARDY always trigger after hitting this?
>
> Regards,
>
> Tony

Yep, the ARDY always gets set after a new command when register access is ready so there's no need for NACK interrupt to control this.

-Reid