From: Andreas Kemnade <andreas@kemnade.info>
To: tony@atomide.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andreas@kemnade.info, hns@goldelico.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, aaro.koskinen@iki.fi,
khilman@baylibre.com, rogerq@kernel.org
Cc: stable@vger.kernel.org
Subject: [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module
Date: Thu, 7 Nov 2024 23:51:00 +0100 [thread overview]
Message-ID: <20241107225100.1803943-1-andreas@kemnade.info> (raw)
Despite CM_IDLEST1_CORE and CM_FCLKEN1_CORE behaving normal,
disabling SPI leads to messages like:
Powerdomain (core_pwrdm) didn't enter target state 0
and according to /sys/kernel/debug/pm_debug/count off state is not
entered. That was not connected to SPI during the discussion
of disabling SPI. See:
https://lore.kernel.org/linux-omap/20230122100852.32ae082c@aktux/
Fix excess DMA channel usage by disabling DMA only instead of disabling
the SPI modules, so powermanagement can da all its work.
Fixes: a622310f7f01 ("ARM: dts: gta04: fix excess dma channel usage")
CC: stable@vger.kernel.org
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
index 3661340009e7a..11f8af34498b1 100644
--- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
@@ -612,19 +612,23 @@ &i2c3 {
};
&mcspi1 {
- status = "disabled";
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&mcspi2 {
- status = "disabled";
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&mcspi3 {
- status = "disabled";
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&mcspi4 {
- status = "disabled";
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
};
&usb_otg_hs {
--
2.39.2
next reply other threads:[~2024-11-07 22:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 22:51 Andreas Kemnade [this message]
2024-11-08 12:42 ` [PATCH] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module Roger Quadros
2024-11-08 17:41 ` Andreas Kemnade
2024-11-09 10:59 ` Roger Quadros
2024-11-11 15:09 ` Tony Lindgren
2024-11-11 18:31 ` Andreas Kemnade
2024-11-11 22:46 ` Andreas Kemnade
2024-11-16 20:27 ` Andreas Kemnade
2024-11-17 11:19 ` Tony Lindgren
2024-11-17 21:22 ` Andreas Kemnade
2024-11-18 13:08 ` Roger Quadros
2024-11-27 22:58 ` Andreas Kemnade
2024-11-28 12:39 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107225100.1803943-1-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox