Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Karol Przybylski <karprzy7@gmail.com>
To: aaro.koskinen@iki.fi, andreas@kemnade.info, khilman@baylibre.com,
	rogerq@kernel.org, tony@atomide.com, lee@kernel.org,
	karprzy7@gmail.com
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org
Subject: [PATCH] mfd: omap-usb-tll: check clk_prepare return code
Date: Wed, 13 Nov 2024 22:16:14 +0100	[thread overview]
Message-ID: <20241113211614.518439-1-karprzy7@gmail.com> (raw)

clk_prepare() is called in usbtll_omap_probe to fill clk array.
Return code is not checked, leaving possible error condition unhandled.

Added variable to hold return value from clk_prepare() and dev_dbg statement
when it's not successful.

Found in coverity scan, CID 1594680

Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
---
 drivers/mfd/omap-usb-tll.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 0f7fdb99c809..2e9319ee1b74 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -202,7 +202,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
 	struct device				*dev =  &pdev->dev;
 	struct usbtll_omap			*tll;
 	void __iomem				*base;
-	int					i, nch, ver;
+	int					i, nch, ver, err;
 
 	dev_dbg(dev, "starting TI HSUSB TLL Controller\n");
 
@@ -248,10 +248,13 @@ static int usbtll_omap_probe(struct platform_device *pdev)
 					"usb_tll_hs_usb_ch%d_clk", i);
 		tll->ch_clk[i] = clk_get(dev, clkname);
 
-		if (IS_ERR(tll->ch_clk[i]))
+		if (IS_ERR(tll->ch_clk[i])) {
 			dev_dbg(dev, "can't get clock : %s\n", clkname);
-		else
-			clk_prepare(tll->ch_clk[i]);
+		} else {
+			err = clk_prepare(tll->ch_clk[i]);
+			if (err)
+				dev_dbg(dev, "clock prepare error for: %s\n", clkname);
+		}
 	}
 
 	pm_runtime_put_sync(dev);
-- 
2.34.1


             reply	other threads:[~2024-11-13 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 21:16 Karol Przybylski [this message]
2024-11-19 13:10 ` [PATCH] mfd: omap-usb-tll: check clk_prepare return code Roger Quadros
2024-11-19 13:56   ` Andreas Kemnade
2024-11-19 14:16     ` Roger Quadros
2024-11-26 22:06       ` Andreas Kemnade
2024-12-05 21:54         ` Karol P
2024-12-05 22:50           ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241113211614.518439-1-karprzy7@gmail.com \
    --to=karprzy7@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=khilman@baylibre.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox