Re: [RFC PATCH 03/10] net: ti: prueth: Adds PRUETH HW and SW configuration

Andrew Lunn
2025-01-09T16:11:00Z

> +/* Below macro is for 1528 Byte Frame support, to Allow even with
> + * Redundancy tag
> + */
> +#define PRUSS_MII_RT_RX_FRMS_MAX_SUPPORT_EMAC (VLAN_ETH_FRAME_LEN + \
> + ETH_FCS_LEN + 6)

Is 6 for the redundancy tag? Is the redundancy tag defined somewhere?
Could this 6 be replaced by a #define, which is maybe a sizeof()?

> + dev_info(dev, "TI PRU ethernet driver initialized: %s EMAC mode\n",
> + (!eth0_node || !eth1_node) ? "single" : "dual");
> +

Is that really true? Is it not in dual mode, but only one interface is
in use? I also wounder at the value of spamming the log like this.

Andrew