linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/7] Add support for BeagleBone Green Eco board
@ 2025-06-13 15:49 Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings Kory Maincent
                   ` (6 more replies)
  0 siblings, 7 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
(BBG). It has minor differences from the BBG, such as a different PMIC,
a different Ethernet PHY, and a larger eMMC.

Also update the omap.yaml binding to include missing compatible strings
that were previously undocumented.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v3:
- Update multi_v7_defconfig with TPS65219 config.
- Remove extraneous compatible strings.
- Replace BeagleBone compatible board name vendor to use "beagle" instead
  of "ti".
- Link to v2: https://lore.kernel.org/r/20250609-bbg-v2-0-5278026b7498@bootlin.com

Changes in v2:
- Add patch 1 to 3 to fix binding and devicetree inconsistencies.
- Rename tps node name to generic pmic node name in am335x-bone-common.
- Link to v1: https://lore.kernel.org/r/20250523-bbg-v1-0-ef4a9e57eeee@bootlin.com

---
Kory Maincent (7):
      dt-bindings: omap: Add missing AM33xx compatible strings
      ARM: dts: omap: Remove incorrect compatible strings from device trees
      arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node
      dt-bindings: omap: Add Seeed BeagleBone Green Eco
      arm: dts: omap: Add support for BeagleBone Green Eco board
      arm: omap2plus_defconfig: Enable TPS65219 regulator
      arm: multi_v7_defconfig: Enable TPS65219 regulator

 Documentation/devicetree/bindings/arm/ti/omap.yaml |  23 ++-
 arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
 arch/arm/boot/dts/ti/omap/am335x-base0033.dts      |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi  |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-bone.dts          |   4 +-
 .../boot/dts/ti/omap/am335x-boneblack-wireless.dts |   4 +-
 arch/arm/boot/dts/ti/omap/am335x-boneblack.dts     |   4 +-
 arch/arm/boot/dts/ti/omap/am335x-boneblue.dts      |   4 +-
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 169 +++++++++++++++++++++
 .../boot/dts/ti/omap/am335x-bonegreen-wireless.dts |   4 +-
 arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts     |   4 +-
 arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts    |   3 +-
 arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts  |   2 +-
 .../arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts  |   4 +-
 .../ti/omap/am335x-sancloud-bbe-extended-wifi.dts  |   5 +-
 .../boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts  |   5 +-
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts  |   2 +-
 arch/arm/boot/dts/ti/omap/am335x-shc.dts           |   2 +-
 arch/arm/configs/multi_v7_defconfig                |   3 +
 arch/arm/configs/omap2plus_defconfig               |   3 +
 21 files changed, 221 insertions(+), 31 deletions(-)
---
base-commit: e22b9ddaf3afd031abc350c303c7c07a51c569d8
change-id: 20250523-bbg-769018d1f2a7

Best regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 17:10   ` Andrew Davis
  2025-06-13 15:49 ` [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Add several compatible strings that were missing from the binding
documentation for AM33xx-based boards. Update vendor prefix from
"ti" to "beagle" for BeagleBone to match actual hardware vendors.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v3:
- Change vendor prefix from ti to beagle
- Remove BeagleBone board variant description.

Change in v2:
- New patch
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 3603edd7361d..45fa1c61cafd 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -104,12 +104,32 @@ properties:
       - description: TI AM33 based platform
         items:
           - enum:
+              - beagle,am335x-bone
+              - beagle,am335x-bone-black
+              - beagle,am335x-bone-black-wireless
+              - beagle,am335x-bone-blue
+              - beagle,am335x-pocketbeagle
+              - bosch,am335x-guardian
               - compulab,cm-t335
+              - grinn,am335x-chiliboard
+              - grinn,am335x-chilisom
+              - gumstix,am335x-pepper
+              - isee,am335x-base0033
+              - moxa,uc-2101
               - moxa,uc-8100-me-t
+              - myir,myc-am335x
+              - myir,myd-am335x
               - novatech,am335x-lxm
-              - ti,am335x-bone
+              - oct,osd3358-sm-refdesign
+              - sancloud,am335x-boneenhanced
+              - seeed,am335x-bone-green
+              - seeed,am335x-bone-green-wireless
+              - tcl,am335x-sl50
               - ti,am335x-evm
+              - ti,am335x-evmsk
+              - ti,am335x-shc
               - ti,am3359-icev2
+              - vscom,onrisc
           - const: ti,am33xx
 
       - description: Compulab board variants based on TI AM33

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 20:33   ` Jason Kridner
       [not found]   ` <CA+T6QPnaCFZyRsv9q3bcOrTc22nA0AOXy0tR_SpAkGVVPQqfLg@mail.gmail.com>
  2025-06-13 15:49 ` [PATCH v3 3/7] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node Kory Maincent
                   ` (4 subsequent siblings)
  6 siblings, 2 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Several device trees incorrectly included extraneous compatible strings
in their compatible property lists. The policy is to only describe the
specific board name and SoC name to avoid confusion.

Remove these incorrect compatible strings to fix the inconsistency.

Also fix board vendor prefixes for BeagleBoard variants that were
incorrectly using "ti" instead of "beagle" or "seeed".

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v3:
- Remove extraneous compatible strings.
- Replace BeagleBone board name vendor.

Changes in v2:
- New patch
---
 arch/arm/boot/dts/ti/omap/am335x-base0033.dts                   | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-bone.dts                       | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts         | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblack.dts                  | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-boneblue.dts                   | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts         | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts                  | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts                 | 3 +--
 arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts               | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts             | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts               | 4 ++--
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts          | 5 +----
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts               | 2 +-
 arch/arm/boot/dts/ti/omap/am335x-shc.dts                        | 2 +-
 15 files changed, 22 insertions(+), 29 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
index 46078af4b7a3..176de29de2a6 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
@@ -9,7 +9,7 @@
 
 / {
 	model = "IGEP COM AM335x on AQUILA Expansion";
-	compatible = "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx";
+	compatible = "isee,am335x-base0033", "ti,am33xx";
 
 	hdmi {
 		compatible = "ti,tilcdc,slave";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
index b5d85ef51a02..2790c0c5a473 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
@@ -8,8 +8,8 @@
 #include "am335x-bone-common.dtsi"
 
 / {
-	model = "TI AM335x BeagleBone";
-	compatible = "ti,am335x-bone", "ti,am33xx";
+	model = "AM335x BeagleBone";
+	compatible = "beagle,am335x-bone", "ti,am33xx";
 };
 
 &ldo3_reg {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
index b4b4b80df08c..d78b6427b8f2 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
@@ -11,8 +11,8 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
-	model = "TI AM335x BeagleBone Black Wireless";
-	compatible = "ti,am335x-bone-black-wireless", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	model = "AM335x BeagleBone Black Wireless";
+	compatible = "beagle,am335x-bone-black-wireless", "ti,am33xx";
 
 	wlan_en_reg: fixedregulator@2 {
 		compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
index 16b567e3cb47..70c26d090ecb 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
@@ -10,8 +10,8 @@
 #include "am335x-boneblack-hdmi.dtsi"
 
 / {
-	model = "TI AM335x BeagleBone Black";
-	compatible = "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	model = "AM335x BeagleBone Black";
+	compatible = "beagle,am335x-bone-black", "ti,am33xx";
 };
 
 &cpu0_opp_table {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
index f579df4c2c54..779e74218b57 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
@@ -9,8 +9,8 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
-	model = "TI AM335x BeagleBone Blue";
-	compatible = "ti,am335x-bone-blue", "ti,am33xx";
+	model = "AM335x BeagleBone Blue";
+	compatible = "beagle,am335x-bone-blue", "ti,am33xx";
 
 	chosen {
 		stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
index a4f5b5262645..ee92abf43175 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
@@ -10,8 +10,8 @@
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
-	model = "TI AM335x BeagleBone Green Wireless";
-	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	model = "Seeed AM335x BeagleBone Green Wireless";
+	compatible = "seeed,am335x-bone-green-wireless", "ti,am33xx";
 
 	wlan_en_reg: fixedregulator@2 {
 		compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
index 18cc0f49e999..3d771721dcb8 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
@@ -9,6 +9,6 @@
 #include "am335x-bonegreen-common.dtsi"
 
 / {
-	model = "TI AM335x BeagleBone Green";
-	compatible = "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	model = "Seeed AM335x BeagleBone Green";
+	compatible = "seeed,am335x-bone-green", "ti,am33xx";
 };
diff --git a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
index 648e97fe1dfd..224095304ef3 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
@@ -8,8 +8,7 @@
 
 / {
 	model = "AM335x Chiliboard";
-	compatible = "grinn,am335x-chiliboard", "grinn,am335x-chilisom",
-		     "ti,am33xx";
+	compatible = "grinn,am335x-chiliboard", "ti,am33xx";
 
 	chosen {
 		stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
index fd91a3c01a63..55a454f51148 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
@@ -12,7 +12,7 @@
 
 / {
 	model = "MYIR MYD-AM335X";
-	compatible = "myir,myd-am335x", "myir,myc-am335x", "ti,am33xx";
+	compatible = "myir,myd-am335x", "ti,am33xx";
 
 	chosen {
 		stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
index d28d39728847..d87ac31a16a9 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
@@ -16,7 +16,7 @@
 
 / {
 	model = "Octavo Systems OSD3358-SM-RED";
-	compatible = "oct,osd3358-sm-refdesign", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	compatible = "oct,osd3358-sm-refdesign", "ti,am33xx";
 };
 
 &ldo3_reg {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
index 78ce860e59b3..c2f26687790c 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
@@ -11,8 +11,8 @@
 #include <dt-bindings/leds/common.h>
 
 / {
-	model = "TI AM335x PocketBeagle";
-	compatible = "ti,am335x-pocketbeagle", "ti,am335x-bone", "ti,am33xx";
+	model = "AM335x PocketBeagle";
+	compatible = "beagle,am335x-pocketbeagle", "ti,am33xx";
 
 	chosen {
 		stdout-path = &uart0;
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
index 7c9f65126c63..61210f975542 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
@@ -13,10 +13,7 @@
 
 / {
 	model = "SanCloud BeagleBone Enhanced Extended WiFi";
-	compatible = "sancloud,am335x-boneenhanced",
-		     "ti,am335x-bone-black",
-		     "ti,am335x-bone",
-		     "ti,am33xx";
+	compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
 
 	wlan_en_reg: fixedregulator@2 {
 		compatible = "regulator-fixed";
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
index c6c96f6182a8..10488b55689c 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
@@ -12,10 +12,7 @@
 
 / {
 	model = "SanCloud BeagleBone Enhanced Lite";
-	compatible = "sancloud,am335x-boneenhanced",
-		     "ti,am335x-bone-black",
-		     "ti,am335x-bone",
-		     "ti,am33xx";
+	compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
 };
 
 &am33xx_pinmux {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
index 32669346cefe..f1bdbf053fb2 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
@@ -13,7 +13,7 @@
 
 / {
 	model = "SanCloud BeagleBone Enhanced";
-	compatible = "sancloud,am335x-boneenhanced", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
+	compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
 };
 
 &am33xx_pinmux {
diff --git a/arch/arm/boot/dts/ti/omap/am335x-shc.dts b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
index 597482822608..f2393ff3f4d7 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-shc.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
@@ -12,7 +12,7 @@
 
 / {
 	model = "Bosch SHC";
-	compatible = "ti,am335x-shc", "ti,am335x-bone", "ti,am33xx";
+	compatible = "ti,am335x-shc", "ti,am33xx";
 
 	aliases {
 		mmcblk0 = &mmc1;

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 3/7] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco Kory Maincent
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Rename tps@24 to the generic pmic@24 node name.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v2:
- New patch.
---
 arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi b/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
index c400b7b70d0d..ad1e60a9b6fd 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am335x-bone-common.dtsi
@@ -212,7 +212,7 @@ &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;
 
-	tps: tps@24 {
+	tps: pmic@24 {
 		reg = <0x24>;
 	};
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
                   ` (2 preceding siblings ...)
  2025-06-13 15:49 ` [PATCH v3 3/7] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 16:05   ` Robert Nelson
  2025-06-16 14:52   ` Conor Dooley
  2025-06-13 15:49 ` [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board Kory Maincent
                   ` (2 subsequent siblings)
  6 siblings, 2 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Document the seed,am335x-bone-green-eco compatible string in the
appropriate place within the omap family binding file.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v3:
- New patch
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 45fa1c61cafd..b8f198a7b763 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -123,6 +123,7 @@ properties:
               - oct,osd3358-sm-refdesign
               - sancloud,am335x-boneenhanced
               - seeed,am335x-bone-green
+              - seeed,am335x-bone-green-eco
               - seeed,am335x-bone-green-wireless
               - tcl,am335x-sl50
               - ti,am335x-evm

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
                   ` (3 preceding siblings ...)
  2025-06-13 15:49 ` [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 16:03   ` Robert Nelson
  2025-06-13 15:49 ` [PATCH v3 6/7] arm: omap2plus_defconfig: Enable TPS65219 regulator Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 7/7] arm: multi_v7_defconfig: " Kory Maincent
  6 siblings, 1 reply; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
(BBG). It has minor differences from the BBG, such as a different PMIC,
a different Ethernet PHY, and a larger eMMC.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v3:
- Move the omap.yaml binding change in another patch.

Changes in v2:
- Used generic pmic node name.
- Add regulator prefix to fixed regulator node name.
- Add the compatible to omap.yaml binding
---
 arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
 arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 169 +++++++++++++++++++++
 2 files changed, 170 insertions(+)

diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
index 95c68135dd0c..1aef60eef671 100644
--- a/arch/arm/boot/dts/ti/omap/Makefile
+++ b/arch/arm/boot/dts/ti/omap/Makefile
@@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
 	am335x-boneblue.dtb \
 	am335x-bonegreen.dtb \
 	am335x-bonegreen-wireless.dtb \
+	am335x-bonegreen-eco.dtb \
 	am335x-chiliboard.dtb \
 	am335x-cm-t335.dtb \
 	am335x-evm.dtb \
diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
new file mode 100644
index 000000000000..2e6050bd2da1
--- /dev/null
+++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2025 Bootlin
+ */
+/dts-v1/;
+
+#include "am33xx.dtsi"
+#include "am335x-bone-common.dtsi"
+#include "am335x-bonegreen-common.dtsi"
+#include <dt-bindings/net/ti-dp83867.h>
+
+/ {
+	model = "TI AM335x BeagleBone Green Eco";
+	compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";
+
+	cpus {
+		cpu@0 {
+			cpu0-supply = <&buck1>;
+		};
+	};
+
+	sys_5v: regulator-sys-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "sys_5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
+	v3v3: regulator-v3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "v3v3";
+		regulator-always-on;
+	};
+};
+
+&usb0 {
+	interrupts-extended = <&intc 18>;
+	interrupt-names = "mc";
+};
+
+&baseboard_eeprom {
+	vcc-supply = <&v3v3>;
+};
+
+&i2c0 {
+	/delete-node/ pmic@24;
+
+	tps65214: pmic@30 {
+		compatible = "ti,tps65214";
+		reg = <0x30>;
+		buck1-supply = <&sys_5v>;
+		buck2-supply = <&sys_5v>;
+		buck3-supply = <&sys_5v>;
+		ldo1-supply = <&sys_5v>;
+		ldo2-supply = <&sys_5v>;
+
+		interrupt-parent = <&intc>;
+		interrupts = <7>;
+		pinctrl-0 = <&pmic_irq_pins_default>;
+
+		regulators {
+			buck1: buck1 {
+				regulator-name = "vdd_mpu";
+				regulator-min-microvolt = <925000>;
+				regulator-max-microvolt = <1351500>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck2: buck2 {
+				regulator-name = "vdd_core";
+				regulator-min-microvolt = <925000>;
+				regulator-max-microvolt = <1150000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck3: buck3 {
+				regulator-name = "vdds_ddr";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+			};
+
+			ldo1_reg: ldo1 {
+				regulator-name = "vdd_1v8_1";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo2_reg: ldo2 {
+				regulator-name = "vdd_1v8_2";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&cpsw_port1 {
+	phy-mode = "rgmii-id";
+	phy-handle = <&dp83867_0>;
+	ti,dual-emac-pvid = <1>;
+};
+
+&mac_sw {
+	pinctrl-0 = <&cpsw_b_default>;
+	pinctrl-1 = <&cpsw_b_sleep>;
+};
+
+&davinci_mdio_sw {
+	/delete-node/ ethernet-phy@0;
+
+	dp83867_0: ethernet-phy@0 {
+		reg = <0>;
+		ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
+		ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
+		ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
+		ti,min-output-impedance;
+		ti,dp83867-rxctrl-strap-quirk;
+	};
+};
+
+&am33xx_pinmux {
+	cpsw_b_default: cpsw-b-default-pins {
+		pinctrl-single,pins = <
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_OUTPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE2)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE2)
+		>;
+	};
+
+	cpsw_b_sleep: cpsw-b-sleep-pins {
+		pinctrl-single,pins = <
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_EN, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_DV, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RX_CLK, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD0, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD1, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD2, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_TXD3, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD0, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD1, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD2, PIN_INPUT_PULLDOWN, MUX_MODE7)
+			AM33XX_PADCONF(AM335X_PIN_MII1_RXD3, PIN_INPUT_PULLDOWN, MUX_MODE7)
+		>;
+	};
+
+	pmic_irq_pins_default: pmic-irq-default-pins {
+		pinctrl-single,pins = <
+			AM33XX_IOPAD(AM335X_PIN_NNMI, PIN_INPUT_PULLUP | MUX_MODE0)
+		>;
+	};
+};

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 6/7] arm: omap2plus_defconfig: Enable TPS65219 regulator
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
                   ` (4 preceding siblings ...)
  2025-06-13 15:49 ` [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  2025-06-13 15:49 ` [PATCH v3 7/7] arm: multi_v7_defconfig: " Kory Maincent
  6 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Enable the TPS65219 regulator in the defconfig, as the TPS65214
variant is used by the newly introduced BeagleBoard Green Eco board.

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 arch/arm/configs/omap2plus_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 9f9780c8e62a..2ad669f7b202 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -385,6 +385,7 @@ CONFIG_TOUCHSCREEN_TSC2007=m
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_CPCAP_PWRBUTTON=m
 CONFIG_INPUT_TPS65218_PWRBUTTON=m
+CONFIG_INPUT_TPS65219_PWRBUTTON=m
 CONFIG_INPUT_TWL4030_PWRBUTTON=m
 CONFIG_INPUT_UINPUT=m
 CONFIG_INPUT_PALMAS_PWRBUTTON=m
@@ -454,6 +455,7 @@ CONFIG_MFD_TPS65217=y
 CONFIG_MFD_TI_LP873X=y
 CONFIG_MFD_TI_LP87565=y
 CONFIG_MFD_TPS65218=y
+CONFIG_MFD_TPS65219=y
 CONFIG_MFD_TPS65910=y
 CONFIG_TWL6040_CORE=y
 CONFIG_REGULATOR_CPCAP=y
@@ -470,6 +472,7 @@ CONFIG_REGULATOR_TPS65023=y
 CONFIG_REGULATOR_TPS6507X=y
 CONFIG_REGULATOR_TPS65217=y
 CONFIG_REGULATOR_TPS65218=y
+CONFIG_REGULATOR_TPS65219=y
 CONFIG_REGULATOR_TPS65910=y
 CONFIG_REGULATOR_TWL4030=y
 CONFIG_RC_CORE=m

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v3 7/7] arm: multi_v7_defconfig: Enable TPS65219 regulator
  2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
                   ` (5 preceding siblings ...)
  2025-06-13 15:49 ` [PATCH v3 6/7] arm: omap2plus_defconfig: Enable TPS65219 regulator Kory Maincent
@ 2025-06-13 15:49 ` Kory Maincent
  6 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 15:49 UTC (permalink / raw)
  To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Andrew Davis, Bajjuri Praneeth, Liam Girdwood,
	Mark Brown, Thomas Petazzoni, linux-omap, devicetree,
	linux-kernel, linux-arm-kernel, Kory Maincent

Enable the TPS65219 regulator in the defconfig, as the TPS65214
variant is used by the newly introduced BeagleBoard Green Eco board.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Change in v3:
- New patch.
---
 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 50c170b4619f..76f74103c1f0 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -344,6 +344,7 @@ CONFIG_INPUT_MAX77693_HAPTIC=m
 CONFIG_INPUT_MAX8997_HAPTIC=m
 CONFIG_INPUT_GPIO_DECODER=m
 CONFIG_INPUT_CPCAP_PWRBUTTON=m
+CONFIG_INPUT_TPS65219_PWRBUTTON=m
 CONFIG_INPUT_AXP20X_PEK=m
 CONFIG_INPUT_DA9063_ONKEY=m
 CONFIG_INPUT_ADXL34X=m
@@ -618,6 +619,7 @@ CONFIG_MFD_PALMAS=y
 CONFIG_MFD_TPS65090=y
 CONFIG_MFD_TPS65217=y
 CONFIG_MFD_TPS65218=y
+CONFIG_MFD_TPS65219=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_MFD_STM32_LPTIMER=m
@@ -667,6 +669,7 @@ CONFIG_REGULATOR_TPS62360=y
 CONFIG_REGULATOR_TPS65090=y
 CONFIG_REGULATOR_TPS65217=y
 CONFIG_REGULATOR_TPS65218=y
+CONFIG_REGULATOR_TPS65219=y
 CONFIG_REGULATOR_TPS6586X=y
 CONFIG_REGULATOR_TPS65910=y
 CONFIG_REGULATOR_TWL4030=y

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board
  2025-06-13 15:49 ` [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board Kory Maincent
@ 2025-06-13 16:03   ` Robert Nelson
  2025-06-13 16:15     ` Kory Maincent
  0 siblings, 1 reply; 18+ messages in thread
From: Robert Nelson @ 2025-06-13 16:03 UTC (permalink / raw)
  To: Kory Maincent
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Jason Kridner,
	Andrew Davis, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

On Fri, Jun 13, 2025 at 10:50 AM Kory Maincent
<kory.maincent@bootlin.com> wrote:
>
> SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> (BBG). It has minor differences from the BBG, such as a different PMIC,
> a different Ethernet PHY, and a larger eMMC.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Changes in v3:
> - Move the omap.yaml binding change in another patch.
>
> Changes in v2:
> - Used generic pmic node name.
> - Add regulator prefix to fixed regulator node name.
> - Add the compatible to omap.yaml binding
> ---
>  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 169 +++++++++++++++++++++
>  2 files changed, 170 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
> index 95c68135dd0c..1aef60eef671 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
>         am335x-boneblue.dtb \
>         am335x-bonegreen.dtb \
>         am335x-bonegreen-wireless.dtb \
> +       am335x-bonegreen-eco.dtb \
>         am335x-chiliboard.dtb \
>         am335x-cm-t335.dtb \
>         am335x-evm.dtb \
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> new file mode 100644
> index 000000000000..2e6050bd2da1
> --- /dev/null
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> @@ -0,0 +1,169 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2025 Bootlin
> + */
> +/dts-v1/;
> +
> +#include "am33xx.dtsi"
> +#include "am335x-bone-common.dtsi"
> +#include "am335x-bonegreen-common.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>
> +
> +/ {
> +       model = "TI AM335x BeagleBone Green Eco";
> +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";

Based on [2/7] ARM: dts: omap: Remove incorrect compatible strings
from device trees  this should be???

> +       model = "Seeed AM335x BeagleBone Green Eco";
> +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";

I feel bad as I'm the one who wrote most of these wrong in the first
place that you are claning up for me!

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco
  2025-06-13 15:49 ` [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco Kory Maincent
@ 2025-06-13 16:05   ` Robert Nelson
  2025-06-16 14:52   ` Conor Dooley
  1 sibling, 0 replies; 18+ messages in thread
From: Robert Nelson @ 2025-06-13 16:05 UTC (permalink / raw)
  To: Kory Maincent
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Jason Kridner,
	Andrew Davis, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

On Fri, Jun 13, 2025 at 10:51 AM Kory Maincent
<kory.maincent@bootlin.com> wrote:
>
> Document the seed,am335x-bone-green-eco compatible string in the
> appropriate place within the omap family binding file.

just a small miss (missing e): `seeed,am335x-bone-green-eco`

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board
  2025-06-13 16:03   ` Robert Nelson
@ 2025-06-13 16:15     ` Kory Maincent
  0 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 16:15 UTC (permalink / raw)
  To: Robert Nelson
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Jason Kridner,
	Andrew Davis, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

Le Fri, 13 Jun 2025 11:03:34 -0500,
Robert Nelson <robertcnelson@gmail.com> a écrit :

> On Fri, Jun 13, 2025 at 10:50 AM Kory Maincent
> <kory.maincent@bootlin.com> wrote:
> >
> > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > a different Ethernet PHY, and a larger eMMC.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >
> > Changes in v3:
> > - Move the omap.yaml binding change in another patch.
> >
> > Changes in v2:
> > - Used generic pmic node name.
> > - Add regulator prefix to fixed regulator node name.
> > - Add the compatible to omap.yaml binding
> > ---
> >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 169
> > +++++++++++++++++++++ 2 files changed, 170 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/Makefile
> > b/arch/arm/boot/dts/ti/omap/Makefile index 95c68135dd0c..1aef60eef671 100644
> > --- a/arch/arm/boot/dts/ti/omap/Makefile
> > +++ b/arch/arm/boot/dts/ti/omap/Makefile
> > @@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
> >         am335x-boneblue.dtb \
> >         am335x-bonegreen.dtb \
> >         am335x-bonegreen-wireless.dtb \
> > +       am335x-bonegreen-eco.dtb \
> >         am335x-chiliboard.dtb \
> >         am335x-cm-t335.dtb \
> >         am335x-evm.dtb \
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> > b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts new file mode 100644
> > index 000000000000..2e6050bd2da1
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> > @@ -0,0 +1,169 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (C) 2025 Bootlin
> > + */
> > +/dts-v1/;
> > +
> > +#include "am33xx.dtsi"
> > +#include "am335x-bone-common.dtsi"
> > +#include "am335x-bonegreen-common.dtsi"
> > +#include <dt-bindings/net/ti-dp83867.h>
> > +
> > +/ {
> > +       model = "TI AM335x BeagleBone Green Eco";
> > +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";  
> 
> Based on [2/7] ARM: dts: omap: Remove incorrect compatible strings
> from device trees  this should be???
> 
> > +       model = "Seeed AM335x BeagleBone Green Eco";
> > +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";  

Oh right, forgot to change the model. Thanks!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings
  2025-06-13 15:49 ` [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings Kory Maincent
@ 2025-06-13 17:10   ` Andrew Davis
  2025-06-13 17:21     ` Kory Maincent
  0 siblings, 1 reply; 18+ messages in thread
From: Andrew Davis @ 2025-06-13 17:10 UTC (permalink / raw)
  To: Kory Maincent, Tony Lindgren, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aaro Koskinen, Andreas Kemnade, Kevin Hilman,
	Roger Quadros, Russell King, Paul Barker, Marc Murphy
  Cc: Jason Kridner, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

On 6/13/25 10:49 AM, Kory Maincent wrote:
> Add several compatible strings that were missing from the binding
> documentation for AM33xx-based boards. Update vendor prefix from
> "ti" to "beagle" for BeagleBone to match actual hardware vendors.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v3:
> - Change vendor prefix from ti to beagle
> - Remove BeagleBone board variant description.
> 
> Change in v2:
> - New patch
> ---
>   Documentation/devicetree/bindings/arm/ti/omap.yaml | 22 +++++++++++++++++++++-
>   1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> index 3603edd7361d..45fa1c61cafd 100644
> --- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
> @@ -104,12 +104,32 @@ properties:
>         - description: TI AM33 based platform
>           items:
>             - enum:
> +              - beagle,am335x-bone
> +              - beagle,am335x-bone-black
> +              - beagle,am335x-bone-black-wireless
> +              - beagle,am335x-bone-blue
> +              - beagle,am335x-pocketbeagle
> +              - bosch,am335x-guardian
>                 - compulab,cm-t335
> +              - grinn,am335x-chiliboard
> +              - grinn,am335x-chilisom
> +              - gumstix,am335x-pepper
> +              - isee,am335x-base0033
> +              - moxa,uc-2101
>                 - moxa,uc-8100-me-t
> +              - myir,myc-am335x
> +              - myir,myd-am335x
>                 - novatech,am335x-lxm
> -              - ti,am335x-bone
> +              - oct,osd3358-sm-refdesign
> +              - sancloud,am335x-boneenhanced
> +              - seeed,am335x-bone-green
> +              - seeed,am335x-bone-green-wireless
> +              - tcl,am335x-sl50
>                 - ti,am335x-evm
> +              - ti,am335x-evmsk
> +              - ti,am335x-shc

SHC looks like a Bosch board.

Otherwise this looks much nicer now,

Reviewed-by: Andrew Davis <afd@ti.com>

>                 - ti,am3359-icev2
> +              - vscom,onrisc
>             - const: ti,am33xx
>   
>         - description: Compulab board variants based on TI AM33
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings
  2025-06-13 17:10   ` Andrew Davis
@ 2025-06-13 17:21     ` Kory Maincent
  0 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-13 17:21 UTC (permalink / raw)
  To: Andrew Davis
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Jason Kridner,
	Bajjuri Praneeth, Liam Girdwood, Mark Brown, Thomas Petazzoni,
	linux-omap, devicetree, linux-kernel, linux-arm-kernel

Le Fri, 13 Jun 2025 12:10:47 -0500,
Andrew Davis <afd@ti.com> a écrit :

> On 6/13/25 10:49 AM, Kory Maincent wrote:
> > Add several compatible strings that were missing from the binding
> > documentation for AM33xx-based boards. Update vendor prefix from
> > "ti" to "beagle" for BeagleBone to match actual hardware vendors.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > 
> > Change in v3:
> > - Change vendor prefix from ti to beagle
> > - Remove BeagleBone board variant description.
> > 
> > Change in v2:
> > - New patch
> > ---
> >   Documentation/devicetree/bindings/arm/ti/omap.yaml | 22
> > +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > 3603edd7361d..45fa1c61cafd 100644 ---
> > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -104,12 +104,32 @@
> > properties:
> >         - description: TI AM33 based platform
> >           items:
> >             - enum:
> > +              - beagle,am335x-bone
> > +              - beagle,am335x-bone-black
> > +              - beagle,am335x-bone-black-wireless
> > +              - beagle,am335x-bone-blue
> > +              - beagle,am335x-pocketbeagle
> > +              - bosch,am335x-guardian
> >                 - compulab,cm-t335
> > +              - grinn,am335x-chiliboard
> > +              - grinn,am335x-chilisom
> > +              - gumstix,am335x-pepper
> > +              - isee,am335x-base0033
> > +              - moxa,uc-2101
> >                 - moxa,uc-8100-me-t
> > +              - myir,myc-am335x
> > +              - myir,myd-am335x
> >                 - novatech,am335x-lxm
> > -              - ti,am335x-bone
> > +              - oct,osd3358-sm-refdesign
> > +              - sancloud,am335x-boneenhanced
> > +              - seeed,am335x-bone-green
> > +              - seeed,am335x-bone-green-wireless
> > +              - tcl,am335x-sl50
> >                 - ti,am335x-evm
> > +              - ti,am335x-evmsk
> > +              - ti,am335x-shc  
> 
> SHC looks like a Bosch board.

Oh indeed it is, I missed that, thanks!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees
  2025-06-13 15:49 ` [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
@ 2025-06-13 20:33   ` Jason Kridner
       [not found]   ` <CA+T6QPnaCFZyRsv9q3bcOrTc22nA0AOXy0tR_SpAkGVVPQqfLg@mail.gmail.com>
  1 sibling, 0 replies; 18+ messages in thread
From: Jason Kridner @ 2025-06-13 20:33 UTC (permalink / raw)
  To: Kory Maincent
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Andrew Davis,
	Bajjuri Praneeth, Liam Girdwood, Mark Brown, Thomas Petazzoni,
	linux-omap, devicetree, linux-kernel, linux-arm-kernel

On Fri, Jun 13, 2025 at 10:49 AM Kory Maincent
<kory.maincent@bootlin.com> wrote:
>
> Several device trees incorrectly included extraneous compatible strings
> in their compatible property lists. The policy is to only describe the
> specific board name and SoC name to avoid confusion.
>
> Remove these incorrect compatible strings to fix the inconsistency.
>
> Also fix board vendor prefixes for BeagleBoard variants that were
> incorrectly using "ti" instead of "beagle" or "seeed".
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
>
> Changes in v3:
> - Remove extraneous compatible strings.
> - Replace BeagleBone board name vendor.
>
> Changes in v2:
> - New patch
> ---
>  arch/arm/boot/dts/ti/omap/am335x-base0033.dts                   | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-bone.dts                       | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts         | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-boneblack.dts                  | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-boneblue.dts                   | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts         | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts                  | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts                 | 3 +--
>  arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts               | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts             | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts               | 4 ++--
>  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
>  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts          | 5 +----
>  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts               | 2 +-
>  arch/arm/boot/dts/ti/omap/am335x-shc.dts                        | 2 +-
>  15 files changed, 22 insertions(+), 29 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> index 46078af4b7a3..176de29de2a6 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> @@ -9,7 +9,7 @@
>
>  / {
>         model = "IGEP COM AM335x on AQUILA Expansion";
> -       compatible = "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx";
> +       compatible = "isee,am335x-base0033", "ti,am33xx";
>
>         hdmi {
>                 compatible = "ti,tilcdc,slave";
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> index b5d85ef51a02..2790c0c5a473 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> @@ -8,8 +8,8 @@
>  #include "am335x-bone-common.dtsi"
>
>  / {
> -       model = "TI AM335x BeagleBone";
> -       compatible = "ti,am335x-bone", "ti,am33xx";
> +       model = "AM335x BeagleBone";

We have software that looks at these in running systems, so I’d be ok
not to change. If changing, why not “BeagleBoard.org BeagleBone”? Not
sure of the convention to mention the SoC, but AM335x is not part of
the product name.

> +       compatible = "beagle,am335x-bone", "ti,am33xx";
>  };
>
>  &ldo3_reg {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
> index b4b4b80df08c..d78b6427b8f2 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts
> @@ -11,8 +11,8 @@
>  #include <dt-bindings/interrupt-controller/irq.h>
>
>  / {
> -       model = "TI AM335x BeagleBone Black Wireless";
> -       compatible = "ti,am335x-bone-black-wireless", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       model = "AM335x BeagleBone Black Wireless";
> +       compatible = "beagle,am335x-bone-black-wireless", "ti,am33xx";
>
>         wlan_en_reg: fixedregulator@2 {
>                 compatible = "regulator-fixed";
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
> index 16b567e3cb47..70c26d090ecb 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-boneblack.dts
> @@ -10,8 +10,8 @@
>  #include "am335x-boneblack-hdmi.dtsi"
>
>  / {
> -       model = "TI AM335x BeagleBone Black";
> -       compatible = "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       model = "AM335x BeagleBone Black";
> +       compatible = "beagle,am335x-bone-black", "ti,am33xx";
>  };
>
>  &cpu0_opp_table {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
> index f579df4c2c54..779e74218b57 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-boneblue.dts
> @@ -9,8 +9,8 @@
>  #include <dt-bindings/interrupt-controller/irq.h>
>
>  / {
> -       model = "TI AM335x BeagleBone Blue";
> -       compatible = "ti,am335x-bone-blue", "ti,am33xx";
> +       model = "AM335x BeagleBone Blue";
> +       compatible = "beagle,am335x-bone-blue", "ti,am33xx";
>
>         chosen {
>                 stdout-path = &uart0;
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> index a4f5b5262645..ee92abf43175 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> @@ -10,8 +10,8 @@
>  #include <dt-bindings/interrupt-controller/irq.h>
>
>  / {
> -       model = "TI AM335x BeagleBone Green Wireless";
> -       compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       model = "Seeed AM335x BeagleBone Green Wireless";
> +       compatible = "seeed,am335x-bone-green-wireless", "ti,am33xx";
>
>         wlan_en_reg: fixedregulator@2 {
>                 compatible = "regulator-fixed";
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
> index 18cc0f49e999..3d771721dcb8 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts
> @@ -9,6 +9,6 @@
>  #include "am335x-bonegreen-common.dtsi"
>
>  / {
> -       model = "TI AM335x BeagleBone Green";
> -       compatible = "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       model = "Seeed AM335x BeagleBone Green";
> +       compatible = "seeed,am335x-bone-green", "ti,am33xx";
>  };
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
> index 648e97fe1dfd..224095304ef3 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts
> @@ -8,8 +8,7 @@
>
>  / {
>         model = "AM335x Chiliboard";
> -       compatible = "grinn,am335x-chiliboard", "grinn,am335x-chilisom",
> -                    "ti,am33xx";
> +       compatible = "grinn,am335x-chiliboard", "ti,am33xx";
>
>         chosen {
>                 stdout-path = &uart0;
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
> index fd91a3c01a63..55a454f51148 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts
> @@ -12,7 +12,7 @@
>
>  / {
>         model = "MYIR MYD-AM335X";
> -       compatible = "myir,myd-am335x", "myir,myc-am335x", "ti,am33xx";
> +       compatible = "myir,myd-am335x", "ti,am33xx";
>
>         chosen {
>                 stdout-path = &uart0;
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
> index d28d39728847..d87ac31a16a9 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts
> @@ -16,7 +16,7 @@
>
>  / {
>         model = "Octavo Systems OSD3358-SM-RED";
> -       compatible = "oct,osd3358-sm-refdesign", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       compatible = "oct,osd3358-sm-refdesign", "ti,am33xx";
>  };
>
>  &ldo3_reg {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> index 78ce860e59b3..c2f26687790c 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> @@ -11,8 +11,8 @@
>  #include <dt-bindings/leds/common.h>
>
>  / {
> -       model = "TI AM335x PocketBeagle";
> -       compatible = "ti,am335x-pocketbeagle", "ti,am335x-bone", "ti,am33xx";
> +       model = "AM335x PocketBeagle";
> +       compatible = "beagle,am335x-pocketbeagle", "ti,am33xx";
>
>         chosen {
>                 stdout-path = &uart0;
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
> index 7c9f65126c63..61210f975542 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
> @@ -13,10 +13,7 @@
>
>  / {
>         model = "SanCloud BeagleBone Enhanced Extended WiFi";
> -       compatible = "sancloud,am335x-boneenhanced",
> -                    "ti,am335x-bone-black",
> -                    "ti,am335x-bone",
> -                    "ti,am33xx";
> +       compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
>
>         wlan_en_reg: fixedregulator@2 {
>                 compatible = "regulator-fixed";
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
> index c6c96f6182a8..10488b55689c 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts
> @@ -12,10 +12,7 @@
>
>  / {
>         model = "SanCloud BeagleBone Enhanced Lite";
> -       compatible = "sancloud,am335x-boneenhanced",
> -                    "ti,am335x-bone-black",
> -                    "ti,am335x-bone",
> -                    "ti,am33xx";
> +       compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
>  };
>
>  &am33xx_pinmux {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
> index 32669346cefe..f1bdbf053fb2 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts
> @@ -13,7 +13,7 @@
>
>  / {
>         model = "SanCloud BeagleBone Enhanced";
> -       compatible = "sancloud,am335x-boneenhanced", "ti,am335x-bone-black", "ti,am335x-bone", "ti,am33xx";
> +       compatible = "sancloud,am335x-boneenhanced", "ti,am33xx";
>  };
>
>  &am33xx_pinmux {
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-shc.dts b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
> index 597482822608..f2393ff3f4d7 100644
> --- a/arch/arm/boot/dts/ti/omap/am335x-shc.dts
> +++ b/arch/arm/boot/dts/ti/omap/am335x-shc.dts
> @@ -12,7 +12,7 @@
>
>  / {
>         model = "Bosch SHC";
> -       compatible = "ti,am335x-shc", "ti,am335x-bone", "ti,am33xx";
> +       compatible = "ti,am335x-shc", "ti,am33xx";
>
>         aliases {
>                 mmcblk0 = &mmc1;
>
> --
> 2.43.0
>


-- 
Learn about me and setup a meeting at
https://beagleboard.org/about/jkridner - a 501c3 non-profit educating
around open hardware computing

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees
       [not found]   ` <CA+T6QPnaCFZyRsv9q3bcOrTc22nA0AOXy0tR_SpAkGVVPQqfLg@mail.gmail.com>
@ 2025-06-16  8:39     ` Kory Maincent
  2025-06-16 11:39       ` Josua Mayer
  0 siblings, 1 reply; 18+ messages in thread
From: Kory Maincent @ 2025-06-16  8:39 UTC (permalink / raw)
  To: Jason Kridner
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Andrew Davis,
	Bajjuri Praneeth, Liam Girdwood, Mark Brown, Thomas Petazzoni,
	linux-omap, devicetree, linux-kernel, linux-arm-kernel

Le Fri, 13 Jun 2025 13:52:23 -0500,
Jason Kridner <jkridner@gmail.com> a écrit :

> On Fri, Jun 13, 2025 at 10:49 AM Kory Maincent <kory.maincent@bootlin.com>
> wrote:
> 
> > Several device trees incorrectly included extraneous compatible strings
> > in their compatible property lists. The policy is to only describe the
> > specific board name and SoC name to avoid confusion.
> >
> > Remove these incorrect compatible strings to fix the inconsistency.
> >
> > Also fix board vendor prefixes for BeagleBoard variants that were
> > incorrectly using "ti" instead of "beagle" or "seeed".
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> >
> > Changes in v3:
> > - Remove extraneous compatible strings.
> > - Replace BeagleBone board name vendor.
> >
> > Changes in v2:
> > - New patch
> > ---
> >  arch/arm/boot/dts/ti/omap/am335x-base0033.dts                   | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-bone.dts                       | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts         | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-boneblack.dts                  | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-boneblue.dts                   | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts         | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts                  | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts                 | 3 +--
> >  arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts               | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts             | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts               | 4 ++--
> >  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
> >  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts          | 5 +----
> >  arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts               | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-shc.dts                        | 2 +-
> >  15 files changed, 22 insertions(+), 29 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> > b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> > index 46078af4b7a3..176de29de2a6 100644
> > --- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> > +++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
> > @@ -9,7 +9,7 @@
> >
> >  / {
> >         model = "IGEP COM AM335x on AQUILA Expansion";
> > -       compatible = "isee,am335x-base0033", "isee,am335x-igep0033",
> > "ti,am33xx";
> > +       compatible = "isee,am335x-base0033", "ti,am33xx";
> >
> >         hdmi {
> >                 compatible = "ti,tilcdc,slave";
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> > b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> > index b5d85ef51a02..2790c0c5a473 100644
> > --- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> > +++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
> > @@ -8,8 +8,8 @@
> >  #include "am335x-bone-common.dtsi"
> >
> >  / {
> > -       model = "TI AM335x BeagleBone";
> > -       compatible = "ti,am335x-bone", "ti,am33xx";
> > +       model = "AM335x BeagleBone";  
> 
> 
> We have software that looks at these in running systems, so I’d be ok not
> to change. If changing, why not “BeagleBoard.org BeagleBone”? Not sure of
> the convention to mention the SoC, but AM335x is not part of the product
> name.

Is it ok to change it or not then? Ok to move on to BeagleBoard.org.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees
  2025-06-16  8:39     ` Kory Maincent
@ 2025-06-16 11:39       ` Josua Mayer
  2025-06-16 12:29         ` Kory Maincent
  0 siblings, 1 reply; 18+ messages in thread
From: Josua Mayer @ 2025-06-16 11:39 UTC (permalink / raw)
  To: Kory Maincent, Jason Kridner
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Andrew Davis,
	Bajjuri Praneeth, Liam Girdwood, Mark Brown, Thomas Petazzoni,
	linux-omap, devicetree, linux-kernel, linux-arm-kernel

Hi Kory,

Am 16.06.25 um 11:39 schrieb Kory Maincent:
> Le Fri, 13 Jun 2025 13:52:23 -0500,
> Jason Kridner <jkridner@gmail.com> a écrit :
>
>> On Fri, Jun 13, 2025 at 10:49 AM Kory Maincent <kory.maincent@bootlin.com>
>> wrote:
>>
>>> Several device trees incorrectly included extraneous compatible strings
>>> in their compatible property lists. The policy is to only describe the
>>> specific board name and SoC name to avoid confusion.
>>>
>>> Remove these incorrect compatible strings to fix the inconsistency.
>>>
>>> Also fix board vendor prefixes for BeagleBoard variants that were
>>> incorrectly using "ti" instead of "beagle" or "seeed".
>>>
>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>>> ---
>>>
>>> Changes in v3:
>>> - Remove extraneous compatible strings.
>>> - Replace BeagleBone board name vendor.
>>>
>>> Changes in v2:
>>> - New patch
>>> ---
>>>   arch/arm/boot/dts/ti/omap/am335x-base0033.dts                   | 2 +-
>>>   arch/arm/boot/dts/ti/omap/am335x-bone.dts                       | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-boneblack-wireless.dts         | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-boneblack.dts                  | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-boneblue.dts                   | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts         | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts                  | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-chiliboard.dts                 | 3 +--
>>>   arch/arm/boot/dts/ti/omap/am335x-myirtech-myd.dts               | 2 +-
>>>   arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts             | 2 +-
>>>   arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts               | 4 ++--
>>>   arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 5 +----
>>>   arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-lite.dts          | 5 +----
>>>   arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe.dts               | 2 +-
>>>   arch/arm/boot/dts/ti/omap/am335x-shc.dts                        | 2 +-
>>>   15 files changed, 22 insertions(+), 29 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
>>> b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
>>> index 46078af4b7a3..176de29de2a6 100644
>>> --- a/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
>>> +++ b/arch/arm/boot/dts/ti/omap/am335x-base0033.dts
>>> @@ -9,7 +9,7 @@
>>>
>>>   / {
>>>          model = "IGEP COM AM335x on AQUILA Expansion";
>>> -       compatible = "isee,am335x-base0033", "isee,am335x-igep0033",
>>> "ti,am33xx";
>>> +       compatible = "isee,am335x-base0033", "ti,am33xx";
>>>
>>>          hdmi {
>>>                  compatible = "ti,tilcdc,slave";
>>> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
>>> b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
>>> index b5d85ef51a02..2790c0c5a473 100644
>>> --- a/arch/arm/boot/dts/ti/omap/am335x-bone.dts
>>> +++ b/arch/arm/boot/dts/ti/omap/am335x-bone.dts
>>> @@ -8,8 +8,8 @@
>>>   #include "am335x-bone-common.dtsi"
>>>
>>>   / {
>>> -       model = "TI AM335x BeagleBone";
>>> -       compatible = "ti,am335x-bone", "ti,am33xx";
>>> +       model = "AM335x BeagleBone";
>>
>> We have software that looks at these in running systems, so I’d be ok not
>> to change. If changing, why not “BeagleBoard.org BeagleBone”? Not sure of
>> the convention to mention the SoC, but AM335x is not part of the product
>> name.
> Is it ok to change it or not then? Ok to move on to BeagleBoard.org.
The Debian project most notably uses the "model" string:

https://salsa.debian.org/installer-team/flash-kernel/-/blob/master/db/all.db?ref_type=heads#L2191

When that changes inside a dtb by kernel update, users may be unable to 
boot.
Therefore I would recommend against changing "model" values.

sincerely
Josua Mayer

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees
  2025-06-16 11:39       ` Josua Mayer
@ 2025-06-16 12:29         ` Kory Maincent
  0 siblings, 0 replies; 18+ messages in thread
From: Kory Maincent @ 2025-06-16 12:29 UTC (permalink / raw)
  To: Josua Mayer
  Cc: Jason Kridner, Tony Lindgren, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Aaro Koskinen, Andreas Kemnade, Kevin Hilman,
	Roger Quadros, Russell King, Paul Barker, Marc Murphy,
	Andrew Davis, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

Le Mon, 16 Jun 2025 14:39:03 +0300,
Josua Mayer <josua.mayer@jm0.eu> a écrit :

> Hi Kory,
> 
> Am 16.06.25 um 11:39 schrieb Kory Maincent:
> > Le Fri, 13 Jun 2025 13:52:23 -0500,
> > Jason Kridner <jkridner@gmail.com> a écrit :
> >  
> >> On Fri, Jun 13, 2025 at 10:49 AM Kory Maincent <kory.maincent@bootlin.com>
> >> wrote:
> >>  
>  [...]  
> >>
> >> We have software that looks at these in running systems, so I’d be ok not
> >> to change. If changing, why not “BeagleBoard.org BeagleBone”? Not sure of
> >> the convention to mention the SoC, but AM335x is not part of the product
> >> name.  
> > Is it ok to change it or not then? Ok to move on to BeagleBoard.org.  
> The Debian project most notably uses the "model" string:
> 
> https://salsa.debian.org/installer-team/flash-kernel/-/blob/master/db/all.db?ref_type=heads#L2191
> 
> When that changes inside a dtb by kernel update, users may be unable to 
> boot.
> Therefore I would recommend against changing "model" values.

Maybe they will have to follow the change.
Don't know if this should not be changed over time even if they are wrong from
the beginning.

It would be nice to have a devicetree maintainer's opinion on this but I don't
think they will reach this message.

I think I will keep old model values for this series then, I don't want to
block this series on this topic.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco
  2025-06-13 15:49 ` [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco Kory Maincent
  2025-06-13 16:05   ` Robert Nelson
@ 2025-06-16 14:52   ` Conor Dooley
  1 sibling, 0 replies; 18+ messages in thread
From: Conor Dooley @ 2025-06-16 14:52 UTC (permalink / raw)
  To: Kory Maincent
  Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Aaro Koskinen, Andreas Kemnade, Kevin Hilman, Roger Quadros,
	Russell King, Paul Barker, Marc Murphy, Jason Kridner,
	Andrew Davis, Bajjuri Praneeth, Liam Girdwood, Mark Brown,
	Thomas Petazzoni, linux-omap, devicetree, linux-kernel,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

On Fri, Jun 13, 2025 at 05:49:47PM +0200, Kory Maincent wrote:
> Document the seed,am335x-bone-green-eco compatible string in the
> appropriate place within the omap family binding file.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2025-06-16 14:52 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-13 15:49 [PATCH v3 0/7] Add support for BeagleBone Green Eco board Kory Maincent
2025-06-13 15:49 ` [PATCH v3 1/7] dt-bindings: omap: Add missing AM33xx compatible strings Kory Maincent
2025-06-13 17:10   ` Andrew Davis
2025-06-13 17:21     ` Kory Maincent
2025-06-13 15:49 ` [PATCH v3 2/7] ARM: dts: omap: Remove incorrect compatible strings from device trees Kory Maincent
2025-06-13 20:33   ` Jason Kridner
     [not found]   ` <CA+T6QPnaCFZyRsv9q3bcOrTc22nA0AOXy0tR_SpAkGVVPQqfLg@mail.gmail.com>
2025-06-16  8:39     ` Kory Maincent
2025-06-16 11:39       ` Josua Mayer
2025-06-16 12:29         ` Kory Maincent
2025-06-13 15:49 ` [PATCH v3 3/7] arm: dts: omap: am335x-bone-common: Rename tps to generic pmic node Kory Maincent
2025-06-13 15:49 ` [PATCH v3 4/7] dt-bindings: omap: Add Seeed BeagleBone Green Eco Kory Maincent
2025-06-13 16:05   ` Robert Nelson
2025-06-16 14:52   ` Conor Dooley
2025-06-13 15:49 ` [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board Kory Maincent
2025-06-13 16:03   ` Robert Nelson
2025-06-13 16:15     ` Kory Maincent
2025-06-13 15:49 ` [PATCH v3 6/7] arm: omap2plus_defconfig: Enable TPS65219 regulator Kory Maincent
2025-06-13 15:49 ` [PATCH v3 7/7] arm: multi_v7_defconfig: " Kory Maincent

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).