* [PATCH v2] mfd: twl4030-irq: remove redundant 'node' variable
@ 2025-06-19 12:03 Abinash Singh
2025-06-19 15:19 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Abinash Singh @ 2025-06-19 12:03 UTC (permalink / raw)
To: aaro.koskinen, andreas, khilman, rogerq, tony
Cc: lee, linux-omap, linux-kernel, Abinash Singh
The local variable 'node' was used only once to retrieve dev->of_node
in a call to irq_domain_create_legacy(). This patch inlines the usage
and removes the redundant variable, improving code clarity.
No functional change intended.
Signed-off-by: Abinash Singh <abinashsinghlalotra@gmail.com>
---
v2 : Corrected the author Name
I am sorry for that .
---
drivers/mfd/twl4030-irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..a2ab5deef9e2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
static struct irq_chip twl4030_irq_chip;
int status, i;
int irq_base, irq_end, nr_irqs;
- struct device_node *node = dev->of_node;
/*
* TWL core and pwr interrupts must be contiguous because
@@ -691,7 +690,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
return irq_base;
}
- irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
+ irq_domain_create_legacy(of_fwnode_handle(dev->of_node), nr_irqs, irq_base, 0,
&irq_domain_simple_ops, NULL);
irq_end = irq_base + TWL4030_CORE_NR_IRQS;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH v2] mfd: twl4030-irq: remove redundant 'node' variable
2025-06-19 12:03 [PATCH v2] mfd: twl4030-irq: remove redundant 'node' variable Abinash Singh
@ 2025-06-19 15:19 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2025-06-19 15:19 UTC (permalink / raw)
To: aaro.koskinen, andreas, khilman, rogerq, tony, Abinash Singh
Cc: lee, linux-omap, linux-kernel, Abinash Singh
On Thu, 19 Jun 2025 17:33:15 +0530, Abinash Singh wrote:
> The local variable 'node' was used only once to retrieve dev->of_node
> in a call to irq_domain_create_legacy(). This patch inlines the usage
> and removes the redundant variable, improving code clarity.
>
> No functional change intended.
>
>
> [...]
Applied, thanks!
[1/1] mfd: twl4030-irq: remove redundant 'node' variable
commit: 3d77b3cc7cc8115d89fa14eaf601e56372953484
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-19 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-19 12:03 [PATCH v2] mfd: twl4030-irq: remove redundant 'node' variable Abinash Singh
2025-06-19 15:19 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).