linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax
@ 2025-08-22 22:25 Jihed Chaibi
  2025-09-05 21:34 ` Kevin Hilman
  2025-09-05 22:22 ` Kevin Hilman
  0 siblings, 2 replies; 3+ messages in thread
From: Jihed Chaibi @ 2025-08-22 22:25 UTC (permalink / raw)
  To: tony
  Cc: krzk+dt, robh, conor+dt, linux-omap, devicetree, linux-kernel,
	shuah, jihed.chaibi.dev

The ti,en-ck32k-xtal property, defined as a boolean in the Device Tree
schema, was incorrectly assigned a value (<1>) in the DTS file, causing
a validation error: "size (4) error for type flag". The driver uses
of_property_read_bool(), expecting a boolean. Remove the value to fix
the dtbs_check error.

Fixes: 262178b6b8e5
Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi b/arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi
index ae2e8dffb..ea47f9960 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi
@@ -269,7 +269,7 @@ &tps {
 	vcc7-supply = <&vbat>;
 	vccio-supply = <&vbat>;
 
-	ti,en-ck32k-xtal = <1>;
+	ti,en-ck32k-xtal;
 
 	regulators {
 		vrtc_reg: regulator@0 {
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax
  2025-08-22 22:25 [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax Jihed Chaibi
@ 2025-09-05 21:34 ` Kevin Hilman
  2025-09-05 22:22 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2025-09-05 21:34 UTC (permalink / raw)
  To: Jihed Chaibi, tony
  Cc: krzk+dt, robh, conor+dt, linux-omap, devicetree, linux-kernel,
	shuah, jihed.chaibi.dev

Jihed Chaibi <jihed.chaibi.dev@gmail.com> writes:

> The ti,en-ck32k-xtal property, defined as a boolean in the Device Tree
> schema, was incorrectly assigned a value (<1>) in the DTS file, causing
> a validation error: "size (4) error for type flag". The driver uses
> of_property_read_bool(), expecting a boolean. Remove the value to fix
> the dtbs_check error.
>
> Fixes: 262178b6b8e5
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>

Nit: fixes tag should include short log like:

Fixes: 262178b6b8e5 ("ARM: dts: split am335x-baltos-ir5221 into dts and dtsi files")

I'll fix this up when applying.

Thanks for the fix!

Kevin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax
  2025-08-22 22:25 [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax Jihed Chaibi
  2025-09-05 21:34 ` Kevin Hilman
@ 2025-09-05 22:22 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2025-09-05 22:22 UTC (permalink / raw)
  To: tony, Jihed Chaibi
  Cc: krzk+dt, robh, conor+dt, linux-omap, devicetree, linux-kernel,
	shuah


On Sat, 23 Aug 2025 00:25:30 +0200, Jihed Chaibi wrote:
> The ti,en-ck32k-xtal property, defined as a boolean in the Device Tree
> schema, was incorrectly assigned a value (<1>) in the DTS file, causing
> a validation error: "size (4) error for type flag". The driver uses
> of_property_read_bool(), expecting a boolean. Remove the value to fix
> the dtbs_check error.
> 
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax
      commit: 9658a92fad1889ff92fa4bd668cd61052687245a

Best regards,
-- 
Kevin Hilman <khilman@baylibre.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-09-05 22:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 22:25 [PATCH] ARM: dts: ti: omap: am335x-baltos: Fix ti,en-ck32k-xtal property in DTS to use correct boolean syntax Jihed Chaibi
2025-09-05 21:34 ` Kevin Hilman
2025-09-05 22:22 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).