From: Anand Moon <linux.amoon@gmail.com>
To: "Vignesh Raghavendra" <vigneshr@ti.com>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI
DRA7XX/J721E),
linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI
DRA7XX/J721E),
linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER
FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list)
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: [PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value
Date: Tue, 14 Oct 2025 17:02:27 +0530 [thread overview]
Message-ID: <20251014113234.44418-2-linux.amoon@gmail.com> (raw)
In-Reply-To: <20251014113234.44418-1-linux.amoon@gmail.com>
Ensure that the return value from dev_err_probe() is consistently assigned
back to ret in all error paths within j721e_pcie_probe(). This ensures
the original error code are propagation for debugging.
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v1: new patch in this series
---
drivers/pci/controller/cadence/pci-j721e.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index 5bc5ab20aa6d..9c7bfa77a66e 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -569,20 +569,20 @@ static int j721e_pcie_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
- dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
+ ret = dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n");
goto err_get_sync;
}
ret = j721e_pcie_ctrl_init(pcie);
if (ret < 0) {
- dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
+ ret = dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n");
goto err_get_sync;
}
ret = devm_request_irq(dev, irq, j721e_pcie_link_irq_handler, 0,
"j721e-pcie-link-down-irq", pcie);
if (ret < 0) {
- dev_err_probe(dev, ret, "failed to request link state IRQ %d\n", irq);
+ ret = dev_err_probe(dev, ret, "failed to request link state IRQ %d\n", irq);
goto err_get_sync;
}
@@ -599,7 +599,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
ret = cdns_pcie_init_phy(dev, cdns_pcie);
if (ret) {
- dev_err_probe(dev, ret, "Failed to init phy\n");
+ ret = dev_err_probe(dev, ret, "Failed to init phy\n");
goto err_get_sync;
}
@@ -611,7 +611,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
ret = clk_prepare_enable(clk);
if (ret) {
- dev_err_probe(dev, ret, "failed to enable pcie_refclk\n");
+ ret = dev_err_probe(dev, ret, "failed to enable pcie_refclk\n");
goto err_pcie_setup;
}
pcie->refclk = clk;
@@ -638,7 +638,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
case PCI_MODE_EP:
ret = cdns_pcie_init_phy(dev, cdns_pcie);
if (ret) {
- dev_err_probe(dev, ret, "Failed to init phy\n");
+ ret = dev_err_probe(dev, ret, "Failed to init phy\n");
goto err_get_sync;
}
--
2.50.1
next prev parent reply other threads:[~2025-10-14 11:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 11:32 [PATCH v1 0/3] PCI: j721e: A couple of cleanups Anand Moon
2025-10-14 11:32 ` Anand Moon [this message]
2025-10-18 8:56 ` [PATCH 1/3] PCI: j721e: Propagate dev_err_probe return value Markus Elfring
2025-10-18 9:22 ` Anand Moon
2025-10-18 10:42 ` Markus Elfring
2025-10-19 10:15 ` Anand Moon
2025-10-19 11:12 ` [1/3] " Markus Elfring
2025-10-19 14:45 ` [PATCH 1/3] " Christophe JAILLET
2025-10-19 17:13 ` [1/3] " Markus Elfring
2025-10-19 17:45 ` Markus Elfring
2025-10-18 11:40 ` Markus Elfring
2025-10-19 16:25 ` Markus Elfring
2025-10-18 9:48 ` [PATCH v1 1/3] " Dan Carpenter
2025-10-19 6:00 ` Anand Moon
2025-10-14 11:32 ` [PATCH v1 2/3] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Anand Moon
2025-10-18 9:33 ` [PATCH " Markus Elfring
2025-10-18 9:49 ` [PATCH v1 " Dan Carpenter
2025-10-18 9:53 ` Dan Carpenter
2025-10-14 11:32 ` [PATCH v1 3/3] PCI: j721e: Use inline reset GPIO assignment and drop local variable Anand Moon
2025-10-18 14:20 ` [PATCH " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014113234.44418-2-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).