Re: [PATCH v2 05/15] gpio: pxa: Use modern PM macros

Andy Shevchenko
2025-11-18T12:07:12Z

On Tue, Nov 18, 2025 at 2:50 AM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.

...

> unsigned long irq_mask;
> unsigned long irq_edge_rise;
> unsigned long irq_edge_fall;

> -

Stray blank line removal.

> -#ifdef CONFIG_PM
> unsigned long saved_gplr;
> unsigned long saved_gpdr;
> unsigned long saved_grer;
> unsigned long saved_gfer;
> -#endif

Otherwise, LGTM.

--
With Best Regards,
Andy Shevchenko