Re: [PATCH v5 02/14] gpio: brcmstb: Use modern PM macros

Andy Shevchenko
2025-11-24T13:52:46Z

On Mon, Nov 24, 2025 at 2:40 PM Jonas Gorski <jonas.gorski@gmail.com> wrote:
> On Mon, Nov 24, 2025 at 1:39 AM Jisheng Zhang <jszhang@kernel.org> wrote:

...

> > static const struct dev_pm_ops brcmstb_gpio_pm_ops = {
> > - .suspend_noirq = brcmstb_gpio_suspend,
> > - .resume_noirq = brcmstb_gpio_resume,
> > + .suspend_noirq = pm_sleep_ptr(brcmstb_gpio_suspend),
> > + .resume_noirq = pm_sleep_ptr(brcmstb_gpio_resume),
> > };

...

> > - .pm = &brcmstb_gpio_pm_ops,
> > + .pm = pm_sleep_ptr(&brcmstb_gpio_pm_ops),
>
> won't this cause a "brcmstb_gpio_pm_ops is unused" compile warning for
> !CONFIG_PM_SLEEP?
>
> You probably need to add a __maybe_unused to brcmstb_gpio_pm_ops
> (which incidentally DEFINE_NOIRQ_DEV_PM_OPS() also doesn't set, but
> all other *_DEV_PM_OPS() macros do).

Shouldn't it be covered by the same trick as pm_sleep_ptr() does for functions?

--
With Best Regards,
Andy Shevchenko