Re: [PATCH v2 13/20] drm/tilcdc: Remove the useless module list support

Luca Ceresoli
2025-12-17T14:25:50Z

On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote:
> The tilcdc driver previously supported a sub-module system where
> external display drivers (panels, encoders) could register themselves
> through tilcdc_module_init() and be automatically initialized through
> a module list. This infrastructure became unused after the component
> framework support and panel driver was removed.
>
> Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>

[...]

> @@ -562,24 +533,7 @@ static struct platform_driver tilcdc_platform_driver = {
> .of_match_table = tilcdc_of_match,
> },
> };
> -
> -static int __init tilcdc_drm_init(void)
> -{
> - if (drm_firmware_drivers_only())
> - return -ENODEV;
> -
> - DBG("init");
> - return platform_driver_register(&tilcdc_platform_driver);
> -}
> -
> -static void __exit tilcdc_drm_fini(void)
> -{
> - DBG("fini");
> - platform_driver_unregister(&tilcdc_platform_driver);
> -}
> -
> -module_init(tilcdc_drm_init);
> -module_exit(tilcdc_drm_fini);
> +module_platform_driver(tilcdc_platform_driver);

Is this hunk related to the removal of the module list? Looks like it
should be a separate patch.

With that hunk removed (or kept if I'm wrong and it should stay):
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering