From: Sergey Shtylyov <s.shtylyov@auroraos.dev>
To: Tony Lindgren <tony@atomide.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Linus Walleij <linusw@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-gpio@vger.kernel.org>
Cc: Sergey Shtylyov <s.shtylyov@auroraos.dev>,
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH] pinctrl: single: drop useless assignment in pcs_irq_set()
Date: Fri, 27 Feb 2026 23:15:14 +0300 [thread overview]
Message-ID: <20260227201515.22577-1-s.shtylyov@auroraos.dev> (raw)
In pcs_irq_set(), the 2nd pcs->read() call is only done to flush a posted
write -- the actually read value is ignored. Drop the useless assignment.
Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.
Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
---
The patch is against the for-next branch of Linus W.'s linux-pinctrl.git repo.
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 288c9c9bce9a..d50122c694b9 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1423,7 +1423,7 @@ static inline void pcs_irq_set(struct pcs_soc_data *pcs_soc,
pcs->write(mask, pcswi->reg);
/* flush posted write */
- mask = pcs->read(pcswi->reg);
+ pcs->read(pcswi->reg);
raw_spin_unlock(&pcs->lock);
}
--
2.53.0
reply other threads:[~2026-02-27 20:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227201515.22577-1-s.shtylyov@auroraos.dev \
--to=s.shtylyov@auroraos.dev \
--cc=haojian.zhuang@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox