From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC8BD296BAF; Mon, 11 May 2026 07:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778482964; cv=none; b=RYqJkLWW6SDyMI9tR3HI0QxFWgd9INdP42CdPylbsh8j0+lH+ZUjdV/3iSzulThwVUPqIoP5uCdsoFt/lVtLMnwBxLo03qGZI5fDrbe7ktJ0KkpFTgcBBPhcowmUlR30Iy0wwR5TmlSehP+SzaNxC0M0buG2RxSNAwUb3vPVTSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778482964; c=relaxed/simple; bh=Tdh/N1hAlE0eVbohv0554EUeYZWyi42yp17TIjpju5g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=odlzpxAlM39HRMwZXRDoerpdmuzZgcGJRcc+d3yWv4ZnPFixx/r9Su2CurI+bvBQtwTCos4i8XJ8dHQln4d1ZuMy6Xw5dk0jVBdfncnspN7cf9K8lvOsJO/qahbc3f1P0ssNNQW3w8QK6OltJlyh/cvPOq5Gp/vFajtufRExa4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OHLDXMEP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OHLDXMEP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25F36C2BCB0; Mon, 11 May 2026 07:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778482964; bh=Tdh/N1hAlE0eVbohv0554EUeYZWyi42yp17TIjpju5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHLDXMEPFhnZDfHYyDEV5HluzVN5NysVQFyveHi6v7Cwmy2warBhBJMzSqMWLQ4hY 0GugpNj51s6Ah+Bmc8EEmgqQbmAu4UYyMqRj/8bww+Cyac+DR2d6INKbeSvhSASHWM CyQBcpQkbbXKLZsNWeGsADXKg3LSTYmnvc4iuPnvonT1VuCmTiPJeyu/HqHDxAgy1J 0GYltnvXZs+anrTpbMeCaGzGf5L/cjcPojB6vWaRSt0vbmYLVfndNx9Bx3C20G1TlB 2pbKXHZ/74Z0ZYrQh8zJQUmiYb5MAa1n16jri7Mi3w0RPE87UVQeEU0U7Co6JikQcF MQW/FE2gv/KCg== Date: Mon, 11 May 2026 16:02:42 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Hans Zhang <18255117159@163.com> Cc: bhelgaas@google.com, lpieralisi@kernel.org, mani@kernel.org, vigneshr@ti.com, jingoohan1@gmail.com, thomas.petazzoni@bootlin.com, pali@kernel.org, ryder.lee@mediatek.com, claudiu.beznea.uj@bp.renesas.com, mpillai@cadence.com, robh@kernel.org, s-vadapalli@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, claudiu.beznea@tuxon.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/7] PCI: dwc: Use common pci_host_common_link_train_delay() helper Message-ID: <20260511070139.GA1096586@rocinante> References: <20260511055923.37117-1-18255117159@163.com> <20260511055923.37117-5-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511055923.37117-5-18255117159@163.com> Hello, > - /* > - * As per PCIe r6.0, sec 6.6.1, a Downstream Port that supports Link > - * speeds greater than 5.0 GT/s, software must wait a minimum of 100 ms > - * after Link training completes before sending a Configuration Request. > - */ > - if (pci->max_link_speed > 2) > - msleep(PCIE_RESET_CONFIG_WAIT_MS); > + pci_host_common_link_train_delay(pci->max_link_speed); This comment could move to the helper you added. Thank you! Krzysztof