From: Nathan Chancellor <nathan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] memory: omap-gpmc: Silence clang kerneldoc warnings
Date: Tue, 19 May 2026 09:14:02 -0700 [thread overview]
Message-ID: <20260519161402.GA3527449@ax162> (raw)
In-Reply-To: <20260519132548.315229-2-krzysztof.kozlowski@oss.qualcomm.com>
On Tue, May 19, 2026 at 03:25:49PM +0200, Krzysztof Kozlowski wrote:
> Recent LLVM prints kerneldoc W=1 warnings, even though a correct
> kerneldoc is there:
I don't see how LLVM is relevant here, a GCC build would show the same
warnings since they come from kernel-doc, not the compiler.
> Warning: drivers/memory/omap-gpmc.c:441 Excess function parameter 'cs' description in 'get_gpmc_timing_reg'
>
> Drop additional inline comments for arguments to fix that. They are
> anyway not that useful.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> drivers/memory/omap-gpmc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index d9e13c1f9b13..958d2b0ea54a 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -432,13 +432,9 @@ static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
> *
> */
> static int get_gpmc_timing_reg(
> - /* timing specifiers */
> int cs, int reg, int st_bit, int end_bit, int max,
> const char *name, const enum gpmc_clk_domain cd,
> - /* value transform */
> - int shift,
> - /* format specifiers */
> - bool raw, bool noval)
> + int shift, bool raw, bool noval)
> {
> u32 l;
> int nr_bits;
> --
> 2.51.0
>
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-19 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 13:25 [PATCH] memory: omap-gpmc: Silence clang kerneldoc warnings Krzysztof Kozlowski
2026-05-19 16:14 ` Nathan Chancellor [this message]
2026-05-19 20:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519161402.GA3527449@ax162 \
--to=nathan@kernel.org \
--cc=justinstitt@google.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox