From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3331516132A; Sat, 23 May 2026 22:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779573920; cv=none; b=ZRfWfKdguydpz+H4UJrsFn4yMVso61lZKm+U0ApNkOwsBvBzU1ebGlnvLfFSz2Y8s9A5tx2g28z/IJjV1K16UyCFdh0rLEU0+QogIT4Jvf+zoShIJUZ4jwfqN+x3tRqwJ18sT4SvHV973ldCXfOpC7oq4ogMJi94TS2aBcEt8zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779573920; c=relaxed/simple; bh=hI2WxIL/SFibqPgCNfqmsJi15LBfE7vwSV9XDng5yMc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SIz9yiz9+l0sf6vBYzDB9rg8kNE8tbFTnoQAkS9D1kEAz3u9tad6N86lv+S0dTl31jozfU4cLdbv1yMGZkDoS0Ghf4Ixokn2CaUTkIDFpjmg9vAPHYm21UIgjw/4qRp8O9nDiYbwvEBsaghd4tZe4U9ucag2rhVFuEocM/my8rM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=29eVPFxr; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="29eVPFxr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Cc:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=5y5C7U0eJNMWpozPRhpxeJdIqeK0zzLaadU8ylQbPm8=; b=29eVPFxrSct7jQWCF+6gO7VEHs zKAP0Qda313Jh20BQWWgKsnRy1pBtFicxbgKdgC+UZNl9mNE2ESJ65O+vwTbr4DBVdTrjeqg6wR8L saOEkvzVEY1VE2xp9ZYWdUfITY1x72Yt4GTaVgaP9gTF3KQqNscluekNakGKl4cro6dHMxjj9xeek 30PT+yCxhZmCUr5AdO9vAW3XdmXNUzWSjQ6w6P3CJSTz/Fx2x+EqkL6U9jymtBr/xAEc8ygNjbuIa H3uj5A9XYEFwlb/lpVf6QpJ7qTtxOjYvw3w11jiicIcuT5SgSwyb57cH/eRRXhlp3NIXzn32Ttvf/ wAifhk3Q==; Date: Sun, 24 May 2026 00:04:52 +0200 From: Andreas Kemnade To: Mithil Bavishi Cc: Aaro Koskinen , Kevin Hilman , Roger Quadros , Tony Lindgren , Russell King , Sami Tolvanen , Kees Cook , Nathan Chancellor , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: OMAP2+: Add CFI type for omap4_finish_suspend Message-ID: <20260524000452.0d67f884@kemnade.info> In-Reply-To: <20260522233036.12277-1-bavishimithil@gmail.com> References: <20260522233036.12277-1-bavishimithil@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 22 May 2026 16:30:36 -0700 Mithil Bavishi wrote: > With CONFIG_CFI enabled, OMAP4 can trap in omap4_enter_lowpower() > because omap_pm_ops.finish_suspend points directly to the assembly > routine omap4_finish_suspend, which lacks the expected KCFI type > metadata. > > Annotate omap4_finish_suspend with SYM_TYPED_FUNC_START so the assembly > routine carries the KCFI type metadata. > > Signed-off-by: Mithil Bavishi Reviewed-by: Andreas Kemnade > --- > arch/arm/mach-omap2/sleep44xx.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/sleep44xx.S b/arch/arm/mach-omap2/sleep44xx.S > index f09c91978..0b48df6fc 100644 > --- a/arch/arm/mach-omap2/sleep44xx.S > +++ b/arch/arm/mach-omap2/sleep44xx.S > @@ -58,7 +58,7 @@ > * stack frame and it expects the caller to take care of it. Hence the entire > * stack frame is saved to avoid possible stack corruption. > */ > -ENTRY(omap4_finish_suspend) > +SYM_TYPED_FUNC_START(omap4_finish_suspend) > stmfd sp!, {r4-r12, lr} > cmp r0, #0x0 > beq do_WFI @ No lowpower state, jump to WFI > @@ -223,7 +223,7 @@ skip_scu_gp_clear: > isb > dsb > ldmfd sp!, {r4-r12, pc} > -ENDPROC(omap4_finish_suspend) > +SYM_FUNC_END(omap4_finish_suspend) > > /* > * ============================