Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Tony Lindgren <tony@atomide.com>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	Marek Vasut <marex@denx.de>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH] drm/omap: dsi: avoid sending bta sync all the time in writes
Date: Sun, 28 Jun 2026 19:00:41 +0200	[thread overview]
Message-ID: <20260628190041.4a30f769@kemnade.info> (raw)
In-Reply-To: <4cb8a90b-6345-47a8-b15a-a977a33af8b3@gmail.com>

On Fri, 29 May 2026 09:26:23 +0300
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> wrote:

> Hi,
> 
> with the following changes:
> 
> user@devuan:/media/user/7b76ddc8-44f5-47b5-af5b-e5e9b5ab39c3/user/linux_openpvrsgx$ 
> git diff drivers/gpu/drm/omapdrm/dss/dsi.c
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c 
> b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index af27339c79f9..8ffcd95c3bc3 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -2199,7 +2199,7 @@ static int dsi_vc_write_common(struct 
> omap_dss_device *dssdev, int vc,
>          int r;
> 
>          if (mipi_dsi_packet_format_is_short(msg->type))
> -               r = dsi_vc_send_short(dsi, vc, msg);
> +               return dsi_vc_send_short(dsi, vc, msg);
>          else
>                  r = dsi_vc_send_long(dsi, vc, msg);
> 
> @@ -3247,21 +3247,6 @@ static int _dsi_update(struct dsi_data *dsi)

do you really need the change from above?
I think it should not be needed with the other changes.
Waiting on short packets seems to work here.

Regards,
Andreas

      reply	other threads:[~2026-06-28 17:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28 10:16 [PATCH] drm/omap: dsi: avoid sending bta sync all the time in writes akemnade
2026-05-28 14:44 ` Ivaylo Dimitrov
2026-05-28 17:02   ` Andreas Kemnade
2026-05-28 17:43     ` Ivaylo Dimitrov
2026-05-28 20:06       ` Andreas Kemnade
2026-05-28 20:19         ` Andreas Kemnade
2026-05-29  6:26           ` Ivaylo Dimitrov
2026-06-28 17:00             ` Andreas Kemnade [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260628190041.4a30f769@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox