Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 06/10] ASoC: ti: omap-dmic: Use dev_err_probe() for error handling
Date: Thu, 16 Jul 2026 16:08:25 +0700	[thread overview]
Message-ID: <20260716090829.72082-7-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260716090829.72082-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Replace dev_err() with dev_err_probe() when handling clock lookup
failures. This preserves the original error code and suppresses
unnecessary deferred probe error messages.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/ti/omap-dmic.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/soc/ti/omap-dmic.c b/sound/soc/ti/omap-dmic.c
index b795b9f66b0e..c8d791f05ae4 100644
--- a/sound/soc/ti/omap-dmic.c
+++ b/sound/soc/ti/omap-dmic.c
@@ -465,10 +465,9 @@ static int asoc_dmic_probe(struct platform_device *pdev)
 	mutex_init(&dmic->mutex);
 
 	dmic->fclk = devm_clk_get(dmic->dev, "fck");
-	if (IS_ERR(dmic->fclk)) {
-		dev_err(dmic->dev, "can't get fck\n");
-		return -ENODEV;
-	}
+	if (IS_ERR(dmic->fclk))
+		return dev_err_probe(dmic->dev, PTR_ERR(dmic->fclk),
+				     "can't get fck\n");
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dma");
 	if (!res) {
-- 
2.43.0


  parent reply	other threads:[~2026-07-16  9:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  9:08 [PATCH v2 00/10] ASoC: ti: Improve probe error handling phucduc.bui
2026-07-16  9:08 ` [PATCH v2 01/10] ASoC: ti: ams-delta: Use dev_err_probe() for " phucduc.bui
2026-07-16  9:08 ` [PATCH v2 02/10] ASoC: ti: davinci-evm: " phucduc.bui
2026-07-16  9:08 ` [PATCH v2 03/10] ASoC: ti: j721e-evm: Return the original error from card name parsing phucduc.bui
2026-07-16  9:08 ` [PATCH v2 04/10] ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log phucduc.bui
2026-07-16  9:08 ` [PATCH v2 05/10] ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling phucduc.bui
2026-07-16  9:08 ` phucduc.bui [this message]
2026-07-16  9:08 ` [PATCH v2 07/10] ASoC: ti: omap-hdmi: " phucduc.bui
2026-07-16  9:28   ` Cezary Rojewski
2026-07-16 10:11     ` Bui Duc Phuc
2026-07-16  9:08 ` [PATCH v2 08/10] ASoC: ti: omap-twl4030: Return the original error code phucduc.bui
2026-07-16  9:08 ` [PATCH v2 09/10] ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling phucduc.bui
2026-07-16  9:08 ` [PATCH v2 10/10] ASoC: ti: rx51: " phucduc.bui
2026-07-16 10:19   ` Cezary Rojewski
2026-07-16 10:41     ` Bui Duc Phuc
2026-07-16 11:15       ` Cezary Rojewski
2026-07-16 12:14         ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716090829.72082-7-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox