From: Andreas Kemnade <andreas@kemnade.info>
To: Eduard Bostina <egbostina@gmail.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, Rob Herring <robh@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
daniel.baluta@nxp.com, simona.toaca@nxp.com,
goledhruva@gmail.com, m-chawdhry@ti.com
Subject: Re: [PATCH v2 2/2] ARM: dts: ti: omap: Disable keypad and enable it on the boards that use it
Date: Wed, 12 Aug 2026 08:09:28 +0200 [thread overview]
Message-ID: <20260812080928.3c9645ae@kemnade.info> (raw)
In-Reply-To: <20260719133730.3551691-3-egbostina@gmail.com>
On Sun, 19 Jul 2026 13:37:30 +0000
Eduard Bostina <egbostina@gmail.com> wrote:
> The keypad node in omap4-l4.dtsi and omap5-l4.dtsi lacks the matrix keymap,
> which is board specific. The binding requires the matrix properties, so the
> incomplete template nodes fail dtbs_check.
>
> Mark the keypad disabled in the SoC files and enable it on the boards
> that actually complete the node with a keymap.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
the ti-sysc stuff will properly disable these things. While a bit anti-pattern
in the OMAP world, it is a more common pattern overall and for the sake
of correct bindings, it is fine. So
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
prev parent reply other threads:[~2026-08-12 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 13:37 [PATCH v2 0/2] dt-bindings: input: Convert TI Keypad Controller to DT schema Eduard Bostina
2026-07-19 13:37 ` [PATCH v2 1/2] " Eduard Bostina
2026-07-21 13:48 ` Rob Herring (Arm)
2026-07-19 13:37 ` [PATCH v2 2/2] ARM: dts: ti: omap: Disable keypad and enable it on the boards that use it Eduard Bostina
2026-08-12 6:09 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812080928.3c9645ae@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=egbostina@gmail.com \
--cc=goledhruva@gmail.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=simona.toaca@nxp.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox