From: Andreas Kemnade <andreas@kemnade.info>
To: Andrew Davis <afd@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Vignesh R <vigneshr@ti.com>,
Kevin Hilman <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] i2c: omap: Drop bit shift for I2C register addresses
Date: Sun, 6 Sep 2026 09:33:01 +0200 [thread overview]
Message-ID: <20260906093301.01fa544e@kemnade.info> (raw)
In-Reply-To: <20260904131252.2126353-2-afd@ti.com>
On Fri, 4 Sep 2026 08:12:45 -0500
Andrew Davis <afd@ti.com> wrote:
> No remaining board device uses a shift other than 2, and no DT supported
> platform ever did. We can drop this flag and use the pre-shifted register
> addresses. This simplifies the register access.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> arch/arm/mach-omap1/i2c.c | 4 ---
> drivers/i2c/busses/i2c-omap.c | 50 +++++++++++---------------
> include/linux/platform_data/i2c-omap.h | 5 ---
> 3 files changed, 21 insertions(+), 38 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/i2c.c b/arch/arm/mach-omap1/i2c.c
> index 94d3e7883e027..bc7828a858941 100644
> --- a/arch/arm/mach-omap1/i2c.c
> +++ b/arch/arm/mach-omap1/i2c.c
> @@ -61,10 +61,6 @@ int __init omap_i2c_add_bus(struct omap_i2c_bus_platform_data *pdata,
> OMAP_I2C_FLAG_16BIT_DATA_REG |
> OMAP_I2C_FLAG_ALWAYS_ARMXOR_CLK;
>
> - /* how the cpu bus is wired up differs for 7xx only */
> -
This could perhaps go into the commit message, but besides of that
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
next prev parent reply other threads:[~2026-09-06 7:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 13:12 [PATCH 0/8] OMAP I2C driver cleanups Andrew Davis
2026-09-04 13:12 ` [PATCH 1/8] i2c: omap: Drop bit shift for I2C register addresses Andrew Davis
2026-09-06 7:33 ` Andreas Kemnade [this message]
2026-09-04 13:12 ` [PATCH 2/8] i2c: omap: Remove unused is_rdr and is_xdr variables Andrew Davis
2026-09-06 7:41 ` Andreas Kemnade
2026-09-04 13:12 ` [PATCH 3/8] i2c: omap: Use devm_pm_runtime_enable() helper Andrew Davis
2026-09-04 13:12 ` [PATCH 4/8] i2c: omap: Combine event flags register definitions Andrew Davis
2026-09-04 13:12 ` [PATCH 5/8] i2c: omap: Use bool for flag values Andrew Davis
2026-09-04 13:12 ` [PATCH 6/8] i2c: omap: Make reset bit name match register name Andrew Davis
2026-09-04 13:12 ` [PATCH 7/8] i2c: omap: Switch to using BIT and GENMASK Andrew Davis
2026-09-04 13:12 ` [PATCH 8/8] i2c: omap: Add OMAP_I2C_BUF_{TX,RX}TRSH definitions Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906093301.01fa544e@kemnade.info \
--to=andreas@kemnade.info \
--cc=afd@ti.com \
--cc=andi.shyti@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox