From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [08/15] usb: musb: Improve PM runtime and phy handling for 2430 glue layer Date: Fri, 09 Sep 2016 22:24:50 +0300 Message-ID: <2068802.BeclS25o24@avalon> References: <1463014396-4095-9-git-send-email-tony@atomide.com> <20160909172447.kw3jb3odlpwt6egv@atomide.com> <3780063.Jn4ozlZU9e@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <3780063.Jn4ozlZU9e@avalon> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren Cc: Bin Liu , Felipe Balbi , George Cherian , Kishon Vijay Abraham I , Ivaylo Dimitrov , Sergei Shtylyov , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org Hi Tony, On Friday 09 Sep 2016 21:33:35 Laurent Pinchart wrote: > On Friday 09 Sep 2016 10:24:47 Tony Lindgren wrote: > > * Laurent Pinchart [160909 10:08]: > > > On Wednesday 11 May 2016 17:53:09 Tony Lindgren wrote: > > > > This simplifies things and allows idling both MUSB and PHY > > > > when nothing is configured. Let's just return early from PM > > > > runtime if musb is not yet initialized. > > > > > > > > Let's also warn if PHY is not configured. > > > > > > git bisect pointed out to this patch today when I tried to find out what > > > broke nfsroot over USB ethernet gadget on my Panda board :-/ Could you > > > help me debugging and fixing that ? > > > > OK, do you have commit 2c5575401e34 ("usb: musb: Fix locking errors for > > host only mode")? That's now in v4.8-rc5. Or which kernel are we talking > > about here? > > I've originally ran into the issue on v4.8-rc2. I've then bisected the issue > to this commit, and confirmed that both v4.7 and v4.8-rc5 are broken. "[PATCH v2] musb: omap2430: do not assume balanced enable()/disable()login register mail settings" (https://patchwork.kernel.org/patch/9261611/) fixes the issue. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html