linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3
Date: Tue, 10 May 2022 10:22:18 +0300	[thread overview]
Message-ID: <20fd1a74-c0f5-d8e9-4903-b74c185d5aa3@kernel.org> (raw)
In-Reply-To: <2b7d411b4a7913335082c858cb0d63b9e4bf7c5b.1652103920.git.geert+renesas@glider.be>

Hi Geert,

On 09/05/2022 16:48, Geert Uytterhoeven wrote:
> The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is
> only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3
> SoCs.  Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent
> asking the user about this driver when configuring a kernel without
> OMAP2+ or K3 SoC family support.
> 
> Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/memory/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index b7800b37af78a996..f00757912e2e4c1e 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -105,6 +105,7 @@ config TI_EMIF
>  config OMAP_GPMC
>  	tristate "Texas Instruments OMAP SoC GPMC driver"
>  	depends on OF_ADDRESS
> +	depends on ARCH_OMAP2PLUS || ARCH_K3 || COMPILE_TEST
>  	select GPIOLIB
>  	help
>  	  This driver is for the General Purpose Memory Controller (GPMC)

Is there any possibility that CONFIG_IRQ_DOMAIN is not set while both
OF_ADDRESS and COMPILE_TEST are set?

That particular case will lead to build failures.

e.g.
https://krzk.eu/#/builders/63/builds/162

cheers,
-roger

  reply	other threads:[~2022-05-10  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 13:48 [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3 Geert Uytterhoeven
2022-05-10  7:22 ` Roger Quadros [this message]
2022-05-10  7:30   ` Geert Uytterhoeven
2022-05-10  7:36     ` Krzysztof Kozlowski
2022-05-10  7:41       ` Roger Quadros
2022-05-10  7:40     ` Roger Quadros
2022-05-10  8:06       ` Geert Uytterhoeven
2022-05-10  8:10         ` Roger Quadros
2022-05-10  8:17           ` Geert Uytterhoeven
2022-05-10  8:27             ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20fd1a74-c0f5-d8e9-4903-b74c185d5aa3@kernel.org \
    --to=rogerq@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).