From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-sound@vger.kernel.org, linux-omap@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] sound: soc: ti: rx51: remove stale reference to machine_is_nokia_rx51()
Date: Sat, 9 May 2026 16:07:31 +0300 [thread overview]
Message-ID: <21e1eeaf-5c8c-488e-89a5-123fc2cc7b1d@bitmer.com> (raw)
In-Reply-To: <20260509012247.14990-1-enelsonmoore@gmail.com>
Hi
On 09/05/2026 4:22 am, Ethan Nelson-Moore wrote:
> The rx51 driver relies on the machine_is_nokia_rx51() macro, which is
> always false since commit 9b7141d01a76 ("ARM: OMAP2+: Drop legacy board
> file for n900"). Its presence prevents the removal of boards no longer
> present in the kernel from arch/arm/tools/mach-types, because the
> machine_is_*() macros are generated from mach-types. Drop this unused
> code.
Not fully true since machine_is_nokia_rx51() still returns true on RX51
(N900) and driver loads successfully both before and after your patch.
But true you may remove this test so please update the commit log and
you may add my tested by tag:
Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
next prev parent reply other threads:[~2026-05-09 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 1:22 [PATCH] sound: soc: ti: rx51: remove stale reference to machine_is_nokia_rx51() Ethan Nelson-Moore
2026-05-09 13:07 ` Jarkko Nikula [this message]
2026-05-09 16:39 ` Ethan Nelson-Moore
2026-05-10 1:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e1eeaf-5c8c-488e-89a5-123fc2cc7b1d@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=broonie@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox