Re: [RFC/PATCH 3/3] i2c: omap: Add support for I2C_M_STOP message flag

[Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]

Hi Shubhrajyoti,

On Wednesday 18 July 2012 11:49:24 Shubhrajyoti wrote:
> On Tuesday 26 June 2012 07:47 PM, Laurent Pinchart wrote:
> > Generate a stop condition after each message marked with I2C_M_STOP.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> > ---
> > 
> >  drivers/i2c/busses/i2c-omap.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index 801df60..cf1bda0 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -545,6 +545,8 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
> > 
> >  	if (dev->speed > 400)
> >  	
> >  		w |= OMAP_I2C_CON_OPMODE_HS;
> > 
> > +	if (msg->flags & I2C_M_STOP)
> > +		stop = 1;
> 
> How about patching omap_i2c_xfer (caller) instead.
> There are some debug prints of stop  above that will not reflect the
> real value.

omap_i2c_xfer() doesn't look at the content of individual messages, I thought 
it was cleaner not to modify that. Note that the message flags are printed in 
the debug message you mention, which is why I've decided to modify the stop 
variable after printing the message. If you think it's better to modify it 
before, we can move this chunk above the dev_dbg().


> >  	if (msg->flags & I2C_M_TEN)
> >  	
> >  		w |= OMAP_I2C_CON_XA;
> >  	
> >  	if (!(msg->flags & I2C_M_RD))

-- 
Regards,

Laurent Pinchart