From: Stephen Boyd <sboyd@kernel.org>
To: "Michael Turquette" <mturquette@baylibre.com>,
"Tero Kristo" <kristo@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 27/30] clk: ti: Convert to platform remove callback returning void
Date: Tue, 28 Mar 2023 19:40:32 -0700 [thread overview]
Message-ID: <22c217f49b5894f2b560500360036689.sboyd@kernel.org> (raw)
In-Reply-To: <20230312161512.2715500-28-u.kleine-koenig@pengutronix.de>
Quoting Uwe Kleine-König (2023-03-12 09:15:09)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to clk-next
next prev parent reply other threads:[~2023-03-29 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 16:14 [PATCH 00/30] clk: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-12 16:15 ` [PATCH 27/30] clk: ti: " Uwe Kleine-König
2023-03-29 2:40 ` Stephen Boyd [this message]
2023-03-15 23:35 ` (subset) [PATCH 00/30] clk: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c217f49b5894f2b560500360036689.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox