linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
	pali.rohar@gmail.com, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] arm: dts: omap3: Add DT entries for OMAP 3
Date: Mon, 16 Mar 2015 02:12:29 +0200	[thread overview]
Message-ID: <2419948.9iuzk7Opkd@avalon> (raw)
In-Reply-To: <1426464080-29119-4-git-send-email-sakari.ailus@iki.fi>

Hi Sakari,

Thank you for the patch.

On Monday 16 March 2015 02:01:19 Sakari Ailus wrote:
> The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx.
> Especially the phy-type property is different.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/omap34xx.dtsi |   17 +++++++++++++++++
>  arch/arm/boot/dts/omap36xx.dtsi |   17 +++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi
> b/arch/arm/boot/dts/omap34xx.dtsi index 3819c1e..7bc8c0f 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -8,6 +8,8 @@
>   * kind, whether express or implied.
>   */
> 
> +#include <dt-bindings/media/omap3-isp.h>
> +
>  #include "omap3.dtsi"
> 
>  / {
> @@ -37,6 +39,21 @@
>  			pinctrl-single,register-width = <16>;
>  			pinctrl-single,function-mask = <0xff1f>;
>  		};
> +
> +		isp: isp@480bc000 {
> +			compatible = "ti,omap3-isp";
> +			reg = <0x480bc000 0x12fc
> +			       0x480bd800 0x017c>;
> +			interrupts = <24>;
> +			iommus = <&mmu_isp>;
> +			syscon = <&omap3_scm_general 0xdc>;
> +			ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> +			#clock-cells = <1>;
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};
> +		};
>  	};
>  };
> 
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi
> b/arch/arm/boot/dts/omap36xx.dtsi index 541704a..3502fe0 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -8,6 +8,8 @@
>   * kind, whether express or implied.
>   */
> 
> +#include <dt-bindings/media/omap3-isp.h>
> +
>  #include "omap3.dtsi"
> 
>  / {
> @@ -69,6 +71,21 @@
>  			pinctrl-single,register-width = <16>;
>  			pinctrl-single,function-mask = <0xff1f>;
>  		};
> +
> +		isp: isp@480bc000 {
> +			compatible = "ti,omap3-isp";
> +			reg = <0x480bc000 0x12fc
> +			       0x480bd800 0x0600>;
> +			interrupts = <24>;
> +			iommus = <&mmu_isp>;
> +			syscon = <&omap3_scm_general 0x2f0>;
> +			ti,phy-type = <OMAP3ISP_PHY_TYPE_CSIPHY>;
> +			#clock-cells = <1>;
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};
> +		};
>  	};
>  };

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-03-16  0:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  0:01 [PATCH 0/4] OMAP 3 ISP (and N9/N950 primary camera support) dts changes Sakari Ailus
2015-03-16  0:01 ` [PATCH 1/4] arm: dts: omap3: Extend the syscon register range Sakari Ailus
2015-03-16  0:16   ` Laurent Pinchart
2015-03-16  0:01 ` [PATCH 2/4] dt: bindings: Add bindings for omap3isp Sakari Ailus
2015-03-16  0:14   ` Laurent Pinchart
2015-03-16  0:01 ` [PATCH 3/4] arm: dts: omap3: Add DT entries for OMAP 3 Sakari Ailus
2015-03-16  0:12   ` Laurent Pinchart [this message]
2015-03-16  0:01 ` [PATCH 4/4] arm: dts: n950, n9: Add primary camera support Sakari Ailus
2015-03-16  0:12   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2419948.9iuzk7Opkd@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sakari.ailus@iki.fi \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).