From: "Ragner N Magalhães" <ragner@users.sourceforge.net>
To: linux-omap-open-source@linux.omap.com
Subject: Fwd: [PATCH]: Workqueue changes for board-h3
Date: Thu, 28 Dec 2006 09:31:55 -0400 [thread overview]
Message-ID: <25c21ceb0612280531u2c01acfase9a95e81e6d37cfe@mail.gmail.com> (raw)
In-Reply-To: <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com>
---------- Forwarded message ----------
From: Felipe Balbi <felipe.lima@indt.org.br>
Date: Dec 28, 2006 9:28 AM
Subject: [PATCH]: Workqueue changes for board-h3
To: ragner.magalhaes@gmail.com
Hello all,
This patch fixes an error regarding workqueue changes on board-h3 file.]
=================== CUT HERE ==========================
Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues.
Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br>
---
Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
===================================================================
--- linux-omap-2.6-dev.orig/arch/arm/mach-omap1/board-h3.c
+++ linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
@@ -298,5 +298,5 @@ static int h3_select_irda(struct device
-static void set_trans_mode(void *data)
+static void set_trans_mode(struct work_struct *data)
{
- int *mode = data;
+ int *mode = (int *)data;
unsigned char expa;
@@ -321,3 +321,3 @@ static void set_trans_mode(void *data)
-static int h3_transceiver_mode(struct device *dev, int
mode)
+static int h3_transceiver_mode(struct device *dev)
{
@@ -326,4 +326,3 @@ static int h3_transceiver_mode(struct de
cancel_delayed_work(&irda_config->gpio_expa);
- PREPARE_WORK(&irda_config->gpio_expa, set_trans_mode, &mode);
-#error this is not permitted - mode is an argument variable
+ PREPARE_WORK(&(irda_config->gpio_expa.work), set_trans_mode);
schedule_delayed_work(&irda_config->gpio_expa, 0);
Index: linux-omap-2.6-dev/include/asm-arm/arch-omap/irda.h
===================================================================
--- linux-omap-2.6-dev.orig/include/asm-arm/arch-omap/irda.h
+++ linux-omap-2.6-dev/include/asm-arm/arch-omap/irda.h
@@ -21,3 +21,3 @@ struct omap_irda_config {
int transceiver_cap;
- int (*transceiver_mode)(struct device *dev, int mode);
+ int (*transceiver_mode)(struct device *dev);
int (*select_irda)(struct device *dev, int state);
Best Regards,
Felipe Balbi
felipe.lima@indt.org.br
Nokia Institute of Technology - INdT
Kernel Developers Team
+55 92 8127 0839
next parent reply other threads:[~2006-12-28 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com>
2006-12-28 13:31 ` Ragner N Magalhães [this message]
2006-12-28 14:48 ` [PATCH]: Workqueue changes for board-h3 Komal Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c21ceb0612280531u2c01acfase9a95e81e6d37cfe@mail.gmail.com \
--to=ragner@users.sourceforge.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox