From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 00/11] Prepare for OMAP2+ movement to Common Clk Date: Wed, 27 Jun 2012 21:56:11 +0200 Message-ID: <2631798.VQ7ROEf9Xv@avalon> References: <1340372890-10091-1-git-send-email-rnayak@ti.com> <1854687.1eeiLuW4oH@avalon> <2606265.VPQJMxIymh@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:35204 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755752Ab2F0T4I (ORCPT ); Wed, 27 Jun 2012 15:56:08 -0400 In-Reply-To: <2606265.VPQJMxIymh@avalon> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Rajendra Nayak , mturquette@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sakari Ailus On Wednesday 27 June 2012 20:45:00 Laurent Pinchart wrote: > On Wednesday 27 June 2012 20:05:27 Laurent Pinchart wrote: > > On Wednesday 27 June 2012 10:36:04 Paul Walmsley wrote: > > > On Wed, 27 Jun 2012, Laurent Pinchart wrote: > > > > I think you've missed drivers/media/video/omap3isp/isp.c. Should I > > > > send > > > > a > > > > patch for that ? Do these changes depend on anything not yet in > > > > mainline > > > > that I should apply to my tree for testing ? > > > > > > What would be ideal is if omap3isp could be converted to runtime PM for > > > its internal IP block control. Almost all of the other OMAP on-chip oC > > > drivers have been converted. Please let us know if more information or > > > assistance is needed with this. > > > > How does that integrate with the clock framework ? > > OK, I think I've found the information. I'll give this a try. Not much luck, pm_runtime_get_sync() doesn't seem to enable the ISP clocks. I'm not familiar with runtime PM internals, what's the call stack from pm_runtime_get_sync() to the arch code that's supposed to enable clocks ? > What is still not clear to me is how runtime PM and system PM interact. For > instance the OMAP3 ISP driver disables its clocks in the system PM suspend > handler, and restarts them in the system PM resume handler. How do I port > that to runtime PM, can I just call pm_runtime_put() and > pm_runtime_get_sync() in the system PM handlers ? -- Regards, Laurent Pinchart