public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Jarkko Nikula <jhnikula@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Girdwood, Liam" <lrg@ti.com>,
	"ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Subject: Re: Re: [PATCH] OMAP4: McBSP: Clear rx_irq at probe time
Date: Tue, 14 Jun 2011 14:19:34 +0300	[thread overview]
Message-ID: <27857936.rzNg0PjYWH@barack> (raw)
In-Reply-To: <20110613133542.GD3352@atomide.com>

Hi Tony,

On Monday 13 June 2011 15:35:43 Tony Lindgren wrote:
> Sure we can merge fixes

Can you take this patch forward?

> but let's get the move done before adding
> new features.

What is considered a new feature here?
Is it a new feature, if I fix the McBSP for OMAP4 (FIFO usage, and small 
updates)?
We have discussion ongoing about the mcbsp code move, and so far the current 
understanding/plan is (Jarkko/Liam correct me if I'm wrong):
- Fix the OMAP4 support
- move the code under sound/soc/omap/
 - the reason for this is that McBSP block can be only used for streaming type 
of modes (from omap2430 onwards McBSP does not have clock stop functionality).
This makes other type of usage hard to say the least.
- Clean up the code (remove the SPI mode, remove unused code paths at the same 
time)
- Consolidate the interface for audio only use
- Only OMAP3 has sidetone (on OMAP2 EAC block has the sidetone), might need 
some change, but I think the current way can be reused.

In this way we are not going to hide the OMAP4 fixes with the code 
move/consolidation effort, so one can track what has been done, and why.

Opinions?

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-06-14 11:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 10:33 [PATCH] OMAP4: McBSP: Clear rx_irq at probe time Peter Ujfalusi
2011-05-17 12:29 ` Jarkko Nikula
2011-05-17 12:57   ` Tony Lindgren
2011-05-18  5:52     ` Peter Ujfalusi
2011-05-18  7:59       ` Jarkko Nikula
2011-05-31  7:52         ` Tony Lindgren
2011-05-18 12:39     ` Peter Ujfalusi
2011-05-31  7:57       ` Tony Lindgren
2011-06-08  7:51         ` Peter Ujfalusi
2011-06-13 13:35           ` Tony Lindgren
2011-06-14 11:19             ` Péter Ujfalusi [this message]
2011-06-14 12:05               ` Jarkko Nikula
2011-06-14 12:40                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27857936.rzNg0PjYWH@barack \
    --to=peter.ujfalusi@ti.com \
    --cc=jhnikula@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox