From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 2/2] ARM: OMAP4+: PRM: fix of_irq_get() result checks Date: Mon, 14 Aug 2017 14:44:12 +0300 Message-ID: <2dfd399c-2760-7d64-a43f-caefde03b39a@cogentembedded.com> References: <20170806151714.108596802@cogentembedded.com> <80dd8051-456b-2331-b847-0631d94f85b1@cogentembedded.com> <20170809220229.GI3934@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170809220229.GI3934@atomide.com> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: Russell King , Paul Walmsley , linux-omap@vger.kernel.org, Rajendra Nayak , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 08/10/2017 01:02 AM, Tony Lindgren wrote: >>> of_irq_get() may return 0 as well as a nagative error number on failure, >> >> Oops, forgot to kill comma... > > I can fix that while applying. Thanks! >>> (and never on success), however omap44xx_prm_late_init() regards 0 as a >>> valid IRQ -- fix this. >>> >>> Fixes: a8f83aefcd5a ("ARM: OMAP4+: PRM: register interrupt information from DT") >>> Fixes: c5b3955828ba ("ARM: OMAP4: Fix legacy code clean-up regression") >>> Signed-off-by: Sergei Shtylyov >> [...] > Seems these both should be safe to apply into fixes-not-urgent for > v4.14 merge window as we have not seen any issues with this? Or Yes, probably. > are there some known bugs related to this? Dunno, I was just auditing the call sites of of_irq_get[_byname]()... > Regards, > > Tony MBR, Sergei