From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: alsa-devel@alsa-project.org
Cc: linux-omap@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ams-delta: fix card initalization failure
Date: Tue, 28 Aug 2012 17:13:05 +0200 [thread overview]
Message-ID: <3048168.EXxi4fR4e7@acer> (raw)
In-Reply-To: <20120827213835.GE4400@opensource.wolfsonmicro.com>
On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
>
> > - platform_set_drvdata(ams_delta_audio_platform_device,
> > - &ams_delta_audio_card);
> > -
> > - ret = platform_device_add(ams_delta_audio_platform_device);
> > - if (ret)
> > - goto err;
>
> The real fix here is that you should be using platform data here, not
> driver data. Is there some reason not to do that?
Mark,
Do you think the change you propose is suitable for the rc cycle? I'm
trying to fix a regression in the first place. Converting the ams-delta
asoc to a platform driver is on my todo list and I'm going to take care
of this as soon as I have enough spare time.
Thanks,
Janusz
next prev parent reply other threads:[~2012-08-28 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 21:28 [PATCH] ASoC: ams-delta: fix card initalization failure Janusz Krzysztofik
2012-08-27 21:38 ` Mark Brown
2012-08-28 15:13 ` Janusz Krzysztofik [this message]
2012-08-28 18:13 ` Mark Brown
2012-08-29 5:04 ` [alsa-devel] " Janusz Krzysztofik
2012-08-31 21:31 ` Mark Brown
2012-09-01 9:09 ` Janusz Krzysztofik
2012-09-06 7:36 ` [alsa-devel] " Mark Brown
2012-09-16 19:17 ` [PATCH] ASoC: ams-delta: Convert to use snd_soc_register_card() Janusz Krzysztofik
2012-09-16 20:44 ` Tony Lindgren
2012-10-02 21:07 ` Janusz Krzysztofik
2012-10-03 10:38 ` Mark Brown
2012-10-03 10:46 ` [RESEND][PATCH] " Janusz Krzysztofik
2012-10-03 13:51 ` Janusz Krzysztofik
2012-10-04 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3048168.EXxi4fR4e7@acer \
--to=jkrzyszt@tis.icnet.pl \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).