Re: OMAP3 previewer bayer pattern selection

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Jean-Philippe,

On Monday 30 April 2012 12:23:27 jean-philippe francois wrote:
> Hi,
> 
> I am trying to get a working preview from a CMOS sensor with a CFA bayer
> pattern.
> 
> Does the CCDC_COLPTN register have any effect on previewer CFA interpolation
> ?

No it doesn't. The CCDC COLPTN register only affects CCDC operation.

> From my experience it does not. I can set BGGR or GRBG, but the output is
> always the same. When doing raw capture, I get nice image if I use a BGGR
> pattern for my software bayer to rgb interpolation. When using previewer,
> the output looks like BGGR interpreted as GRBG, ie blue and red are green,
> and green turns into purple.
> 
> Looking at the driver code (mainline), there is nothing about bayer order
> in the previewer code. Looking at the TRM, theres is also nothing in the
> previewer part about bayer order.
> 
> How are we supposed to debayer something different from GRBG ? By modifying
> the cfa_coef_table table ? Cropping at the previewer output to start on an
> odd line ?

Selecting the CFA pattern requires modifying several registers:

- PCR:CFA_FMT

0x0: Mode 0: conventional Bayer.
0x1: Mode 1: horizontal 2x downsample.
0x2: Mode 2: bypass CFA stage (RGB Foveon X3)
0x3: Mode 3: horizontal and vertical 2x downsample.
0x4: Mode 4: Super CCD Honeycom movie mode sensor.
0x5: Mode5: bypass CFA stage (RRRR GGGG BBBB Foveon X3).

The default value is Bayer, you won't need to change that.

- WBSEL

This register selects which white balance coefficient is applied to which 
pixel. This needs to match the Bayer pattern.

- CFA table

That's where the bulk of the work will be. The CFA coefficients table needs to 
be adjusted based on the Bayer pattern. Unfortunately the publicly available 
TRM doesn't document how the table should be computed.

> Thank you for any pointer on this issue.

-- 
Regards,

Laurent Pinchart