Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

Linus Walleij
2018-07-29T20:33:48Z

Hi Janusz!

Nice work overall! Some feedback:

On Thu, Jul 19, 2018 at 1:57 AM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

> +#include <linux/gpio/driver.h>

Let's skip that.

> + /*
> + * For acceptable performance require the data GPIO
> + * chip to support get/set_multiple() callbacks.
> + */
> + if (!data_gpioc->get_multiple || !data_gpioc->set_multiple) {
> + err = -EINVAL;
> + dev_err(&pdev->dev,
> + "data GPIO chip does not support get/set_multiple()\n");
> + goto out_mtd;
> + }

Since we know which platform it is, we know that we applied the previous
get/set multiple patch, so we need not check this if the patches are
applied in sequence.

As long as all patches go in the same merge window, no problem.

I'm BTW ready to apply the get/set multiple patch already.

Yours,
Linus Walleij