* [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST [not found] <96572680e698fc554310e18cd6a166a0fb3bf32c.1523028795.git.mchehab@s-opensource.com> @ 2018-04-06 15:33 ` Mauro Carvalho Chehab 2018-04-07 11:46 ` Laurent Pinchart 0 siblings, 1 reply; 3+ messages in thread From: Mauro Carvalho Chehab @ 2018-04-06 15:33 UTC (permalink / raw) Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel, Mauro Carvalho Chehab, Mauro Carvalho Chehab, Tomi Valkeinen, linux-omap, Linux Media Mailing List The dependency of DRM_OMAP = n can be relaxed for just compilation test. This allows building the omap3isp driver with allyesconfig on ARM. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -4,7 +4,7 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on DRM_OMAP = n + depends on DRM_OMAP = n || COMPILE_TEST select FB_OMAP2_DSS select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3 -- 2.14.3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST 2018-04-06 15:33 ` [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST Mauro Carvalho Chehab @ 2018-04-07 11:46 ` Laurent Pinchart 2018-04-07 12:44 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 3+ messages in thread From: Laurent Pinchart @ 2018-04-07 11:46 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel, Mauro Carvalho Chehab, Tomi Valkeinen, linux-omap, Linux Media Mailing List Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > The dependency of DRM_OMAP = n can be relaxed for just > compilation test. > > This allows building the omap3isp driver with allyesconfig > on ARM. omapfb has nothing to do with omap3isp. I assume you meant omap_vout. There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same time, they export identical symbols. I believe you will end up with link failures if you do so. > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > --- > drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig > b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c > 100644 > --- a/drivers/video/fbdev/omap2/omapfb/Kconfig > +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig > @@ -4,7 +4,7 @@ config OMAP2_VRFB > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > - depends on DRM_OMAP = n > + depends on DRM_OMAP = n || COMPILE_TEST > > select FB_OMAP2_DSS > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3 -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST 2018-04-07 11:46 ` Laurent Pinchart @ 2018-04-07 12:44 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 3+ messages in thread From: Mauro Carvalho Chehab @ 2018-04-07 12:44 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel, Mauro Carvalho Chehab, Tomi Valkeinen, linux-omap, Linux Media Mailing List Em Sat, 07 Apr 2018 14:46:56 +0300 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote: > > The dependency of DRM_OMAP = n can be relaxed for just > > compilation test. > > > > This allows building the omap3isp driver with allyesconfig > > on ARM. > > omapfb has nothing to do with omap3isp. I assume you meant omap_vout. > > There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same > time, they export identical symbols. I believe you will end up with link > failures if you do so. Ah, OK. I'll just drop this patch. Thanks, Mauro _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-07 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <96572680e698fc554310e18cd6a166a0fb3bf32c.1523028795.git.mchehab@s-opensource.com>
2018-04-06 15:33 ` [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST Mauro Carvalho Chehab
2018-04-07 11:46 ` Laurent Pinchart
2018-04-07 12:44 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).