From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B449C55ABD for ; Mon, 9 Nov 2020 08:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8DCF20E65 for ; Mon, 9 Nov 2020 08:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="eywi2w0V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728335AbgKIIUU (ORCPT ); Mon, 9 Nov 2020 03:20:20 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55830 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgKIIUT (ORCPT ); Mon, 9 Nov 2020 03:20:19 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A98KA7i041533; Mon, 9 Nov 2020 02:20:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604910010; bh=9DVEbiZewaOVjXQFfj+2Ci+gwiTUpJGts+1rhtSb9p0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=eywi2w0VEC3QBO/GL+iiFPM+mYG1r6TheAhl+DUYE6WY07/60LFlUSq/T1OqGhSkn 8+PaLczgoFAmGClf6WF5Ji9E0bV7yFb7qfJM67uyv7x6WmD4dqnMnws/2/N1oph8cz rs6J6pmo+Ecz7F2gcl92FTsaqo9QQzmPaV9lx1k8= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A98KAv4080936 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Nov 2020 02:20:10 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 9 Nov 2020 02:20:10 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 9 Nov 2020 02:20:10 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A98K8L6059388; Mon, 9 Nov 2020 02:20:08 -0600 Subject: Re: [PATCH v3 09/56] drm/omap: dsi: drop virtual channel logic To: Laurent Pinchart CC: Sebastian Reichel , Nikhil Devshatwar , , , Sekhar Nori , Tony Lindgren , "H . Nikolaus Schaller" , Sebastian Reichel References: <20201105120333.947408-1-tomi.valkeinen@ti.com> <20201105120333.947408-10-tomi.valkeinen@ti.com> <20201109081450.GE6029@pendragon.ideasonboard.com> From: Tomi Valkeinen Message-ID: <34e04d90-af9a-1482-4761-3cd633d132fe@ti.com> Date: Mon, 9 Nov 2020 10:20:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201109081450.GE6029@pendragon.ideasonboard.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 09/11/2020 10:14, Laurent Pinchart wrote: > Hi Tomi and Sebastian, > > Thank you for the patch. > > On Thu, Nov 05, 2020 at 02:02:46PM +0200, Tomi Valkeinen wrote: >> From: Sebastian Reichel >> >> This drops the virtual channel logic. Afterwards DSI clients >> request their channel number and get the virtual channel with >> the same number or -EBUSY if already in use. > > It could be useful to explain the reason for this patch (which, if I > understand the patch correctly, is to replace dynamic allocation of > virtual channels with a fixed allocation by the DSI panel, I assume > because dynamic allocation isn't actually useful ?). Yes, I can elaborate on that in v4. I also just sent a separate mail about it. >> Signed-off-by: Sebastian Reichel >> Signed-off-by: Tomi Valkeinen >> --- >> .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 11 ++--- >> drivers/gpu/drm/omapdrm/dss/dsi.c | 46 ++++--------------- >> drivers/gpu/drm/omapdrm/dss/omapdss.h | 4 +- >> 3 files changed, 12 insertions(+), 49 deletions(-) >> >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> index 8b2e80129bd8..ea76a89d1833 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c >> @@ -768,19 +768,12 @@ static int dsicm_connect(struct omap_dss_device *src, >> struct device *dev = &ddata->pdev->dev; >> int r; >> >> - r = src->ops->dsi.request_vc(src, &ddata->channel); >> + r = src->ops->dsi.request_vc(src, ddata->channel); >> if (r) { >> dev_err(dev, "failed to get virtual channel\n"); >> return r; >> } >> >> - r = src->ops->dsi.set_vc_id(src, ddata->channel, TCH); >> - if (r) { >> - dev_err(dev, "failed to set VC_ID\n"); >> - src->ops->dsi.release_vc(src, ddata->channel); >> - return r; >> - } >> - >> ddata->src = src; >> return 0; >> } >> @@ -1215,6 +1208,8 @@ static int dsicm_probe_of(struct platform_device *pdev) >> struct display_timing timing; >> int err; >> >> + ddata->channel = TCH; > > I'd drop the macro, but no big deal. > > Reviewed-by: Laurent Pinchart It's dropped in a later patch. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki