From: Hema Kalliguddi <hemahk-l0cyMroinI0@public.gmane.org>
To: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE:
Date: Wed, 16 Feb 2011 17:47:10 +0530 [thread overview]
Message-ID: <3897a14de7c3109761d242f2b6e54eb2@mail.gmail.com> (raw)
In-Reply-To: <4D5BBC61.2000905-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
Hi,
>-----Original Message-----
>From: Sergei Shtylyov [mailto:sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org]
>Sent: Wednesday, February 16, 2011 5:31 PM
>To: Hema HK
>Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>Subject: Re:
>
>On 16-02-2011 14:53, Hema HK wrote:
>
>> From: Hema HK<hemahk-l0cyMroinI0@public.gmane.org
>
>> Moved all the board specific internal PHY functions out of
>usb_musb.c file
>> as this file is shared between the OMAP2+ and AM35xx platforms.
>> There exists a file which has the functions specific to internal PHY
>> used for OMAP4 platform. Moved all phy specific functions to
>this file
>> and passing these functions through board data in the board file.
>
>> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
>
>> Index: linux-2.6/arch/arm/mach-omap2/board-am3517evm.c
>> ===================================================================
>> --- linux-2.6.orig/arch/arm/mach-omap2/board-am3517evm.c
>> +++ linux-2.6/arch/arm/mach-omap2/board-am3517evm.c
>> @@ -409,6 +409,10 @@ static struct omap_musb_board_data musb_
>> .interface_type = MUSB_INTERFACE_ULPI,
>> .mode = MUSB_OTG,
>> .power = 500,
>> + .set_phy_power = am35x_musb_phy_power,
>> + .clear_irq = am35x_musb_clear_irq,
>> + .set_mode = am35x_musb_set_mode,
>> + .reset = am35x_musb_reset,
>> };
>>
>> static __init void am3517_evm_musb_init(void)
>[...]
>> Index: linux-2.6/arch/arm/mach-omap2/Makefile
>> ===================================================================
>> --- linux-2.6.orig/arch/arm/mach-omap2/Makefile
>> +++ linux-2.6/arch/arm/mach-omap2/Makefile
>> @@ -218,7 +218,8 @@ obj-$(CONFIG_MACH_OMAP4_PANDA) += board
>> hsmmc.o \
>> omap_phy_internal.o
>>
>> -obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
>> +obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o \
>> + omap_phy_internal.o \
>>
>> obj-$(CONFIG_MACH_CRANEBOARD) += board-am3517crane.o
>
> Doesn't the above board needs board data modified as well?
There is no "musb_board_data" for the above board file.
Regards,
Hema
>
>WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-16 12:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 11:53 (unknown), Hema HK
[not found] ` <1297857190-27449-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2011-02-16 11:55 ` your mail Felipe Balbi
2011-02-16 12:00 ` Sergei Shtylyov
[not found] ` <4D5BBC61.2000905-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-02-16 12:17 ` Hema Kalliguddi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-06 2:24 Re: Viviane Jose Pereira
2014-12-06 13:18 Re: Quan Han
2012-07-31 23:52 (unknown), Ricardo Neri
2012-07-31 23:58 ` Ricardo Neri
2011-12-13 2:58 Re: Matt Shaw
2010-07-20 0:22 Re: wins
2010-07-07 18:15 Coca Cola Promo
2010-04-29 2:49 RE: ABC MICROFINANCE BANK (NIG)
2010-01-20 19:47 (no subject) Ben Gamari
2010-01-21 0:04 ` Ben Dooks
2010-01-21 0:04 ` Re: Ben Dooks
2010-01-22 15:53 ` Re: Ben Gamari
2009-12-05 22:29 Irish News Center
2009-08-25 10:34 (unknown), Syed Rafiuddin
2009-08-26 11:10 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3897a14de7c3109761d242f2b6e54eb2@mail.gmail.com \
--to=hemahk-l0cymroini0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).